From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id AAC427F7E for ; Tue, 13 Aug 2013 15:44:18 -0500 (CDT) Date: Tue, 13 Aug 2013 15:44:18 -0500 From: Ben Myers Subject: Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks Message-ID: <20130813204418.GB12719@sgi.com> References: <5209C4D0.5050203@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5209C4D0.5050203@oracle.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jeff Liu Cc: kbuild test robot , "xfs@oss.sgi.com" On Tue, Aug 13, 2013 at 01:32:00PM +0800, Jeff Liu wrote: > From: Jie Liu > > Replace roundup() with roundup_64() as we calculate min_logblks > with 64-bit divisions. Hence, call roundup() will cause the > following error while compiling a 32-bit kernel: > > fs/built-in.o: In function `xfs_log_calc_minimum_size': > fs/xfs/xfs_log_rlimit.c:140: undefined reference to `__udivdi3' > > Reported-by: Fengguang Wu > Cc: Dave Chinner > Signed-off-by: Jie Liu Applied. Thanks Jeff. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs