From: Arnd Bergmann <arnd@arndb.de>
To: Dwight Engen <dwight.engen@oracle.com>
Cc: cbe-oss-dev@lists.ozlabs.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
Ben Myers <bpm@sgi.com>,
linux-next@vger.kernel.org, Gao feng <gaofeng@cn.fujitsu.com>,
linuxppc-dev@lists.ozlabs.org, Jeremy Kerr <jk@ozlabs.org>
Subject: Re: linux-next: build failure after merge of the final tree
Date: Tue, 20 Aug 2013 22:46:30 +0200 [thread overview]
Message-ID: <201308202246.30869.arnd@arndb.de> (raw)
In-Reply-To: <20130820120702.000b044e@oracle.com>
On Tuesday 20 August 2013, Dwight Engen wrote:
> diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
> index f390042..90fb308 100644
> --- a/arch/powerpc/platforms/cell/spufs/inode.c
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> @@ -620,12 +620,12 @@ spufs_parse_options(struct super_block *sb, char *options, struct inode *root)
> case Opt_uid:
> if (match_int(&args[0], &option))
> return 0;
> - root->i_uid = option;
> + root->i_uid = make_kuid(&init_user_ns, option);
> break;
> case Opt_gid:
> if (match_int(&args[0], &option))
> return 0;
> - root->i_gid = option;
> + root->i_gid = make_kgid(&init_user_ns, option);
> break;
> case Opt_mode:
> if (match_octal(&args[0], &option))
Doesn't this mean the uid/gid is taken from the initial namespace rather than
from the namespace of the 'mount' process calling this? I think the logical
choice would be to have the UID be the one that gets passed here in the caller's
namespace.
Arnd
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-20 20:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 7:20 linux-next: build failure after merge of the final tree Stephen Rothwell
2013-08-20 16:07 ` Dwight Engen
2013-08-20 19:28 ` Ben Myers
2013-08-21 0:22 ` Stephen Rothwell
2013-08-21 15:54 ` Ben Myers
2013-08-20 20:46 ` Arnd Bergmann [this message]
2013-08-21 5:08 ` Dwight Engen
2013-08-21 6:30 ` Jeremy Kerr
2013-08-21 15:56 ` Ben Myers
2013-08-21 18:33 ` [PATCH] powerpc/spufs: convert userns uid/gid mount options to kuid/kgid Dwight Engen
2013-08-21 20:05 ` Arnd Bergmann
2013-08-21 20:24 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308202246.30869.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bpm@sgi.com \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=dwight.engen@oracle.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox