From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>,
Mark Tinguely <tinguely@sgi.com>
Subject: Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
Date: Wed, 21 Aug 2013 10:07:04 +1000 [thread overview]
Message-ID: <20130821000704.GP6023@dastard> (raw)
In-Reply-To: <5213F849.7080308@redhat.com>
On Tue, Aug 20, 2013 at 06:14:17PM -0500, Eric Sandeen wrote:
> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
>
> un-static'd alloc_ex_data and used it in phase6.c,
> but didn't put a prototype in a header, so:
>
> phase6.c: In function ‘mk_orphanage’:
> phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
>
> Fix it...
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/repair/incore.h b/repair/incore.h
> index 8a578b5..38caa6d 100644
> --- a/repair/incore.h
> +++ b/repair/incore.h
> @@ -483,6 +483,11 @@ void set_inode_parent(ino_tree_node_t *irec, int ino_offset,
> xfs_ino_t get_inode_parent(ino_tree_node_t *irec, int ino_offset);
>
> /*
> + * Allocate extra inode data
> + */
> +void alloc_ex_data(ino_tree_node_t *irec);
> +
> +/*
> * bmap cursor for tracking and fixing bmap btrees. All xfs btrees number
> * the levels with 0 being the leaf and every level up being 1 greater.
> */
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-21 0:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 23:14 [PATCH] xfs_repair: add prototype for alloc_ex_data() Eric Sandeen
2013-08-21 0:07 ` Dave Chinner [this message]
2013-08-21 14:28 ` Mark Tinguely
2013-08-21 15:28 ` Eric Sandeen
2013-08-21 17:14 ` Rich Johnston
2013-08-21 17:01 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821000704.GP6023@dastard \
--to=david@fromorbit.com \
--cc=linux-xfs@oss.sgi.com \
--cc=sandeen@redhat.com \
--cc=tinguely@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox