* [PATCH] xfs_repair: add prototype for alloc_ex_data()
@ 2013-08-20 23:14 Eric Sandeen
2013-08-21 0:07 ` Dave Chinner
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Eric Sandeen @ 2013-08-20 23:14 UTC (permalink / raw)
To: 'linux-xfs@oss.sgi.com'; +Cc: Mark Tinguely
3ac87fbf xfsprogs: fix inode crash in xfs_repair
un-static'd alloc_ex_data and used it in phase6.c,
but didn't put a prototype in a header, so:
phase6.c: In function ‘mk_orphanage’:
phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
Fix it...
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/repair/incore.h b/repair/incore.h
index 8a578b5..38caa6d 100644
--- a/repair/incore.h
+++ b/repair/incore.h
@@ -483,6 +483,11 @@ void set_inode_parent(ino_tree_node_t *irec, int ino_offset,
xfs_ino_t get_inode_parent(ino_tree_node_t *irec, int ino_offset);
/*
+ * Allocate extra inode data
+ */
+void alloc_ex_data(ino_tree_node_t *irec);
+
+/*
* bmap cursor for tracking and fixing bmap btrees. All xfs btrees number
* the levels with 0 being the leaf and every level up being 1 greater.
*/
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
2013-08-20 23:14 [PATCH] xfs_repair: add prototype for alloc_ex_data() Eric Sandeen
@ 2013-08-21 0:07 ` Dave Chinner
2013-08-21 14:28 ` Mark Tinguely
2013-08-21 17:01 ` Rich Johnston
2 siblings, 0 replies; 6+ messages in thread
From: Dave Chinner @ 2013-08-21 0:07 UTC (permalink / raw)
To: Eric Sandeen; +Cc: 'linux-xfs@oss.sgi.com', Mark Tinguely
On Tue, Aug 20, 2013 at 06:14:17PM -0500, Eric Sandeen wrote:
> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
>
> un-static'd alloc_ex_data and used it in phase6.c,
> but didn't put a prototype in a header, so:
>
> phase6.c: In function ‘mk_orphanage’:
> phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
>
> Fix it...
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/repair/incore.h b/repair/incore.h
> index 8a578b5..38caa6d 100644
> --- a/repair/incore.h
> +++ b/repair/incore.h
> @@ -483,6 +483,11 @@ void set_inode_parent(ino_tree_node_t *irec, int ino_offset,
> xfs_ino_t get_inode_parent(ino_tree_node_t *irec, int ino_offset);
>
> /*
> + * Allocate extra inode data
> + */
> +void alloc_ex_data(ino_tree_node_t *irec);
> +
> +/*
> * bmap cursor for tracking and fixing bmap btrees. All xfs btrees number
> * the levels with 0 being the leaf and every level up being 1 greater.
> */
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
2013-08-20 23:14 [PATCH] xfs_repair: add prototype for alloc_ex_data() Eric Sandeen
2013-08-21 0:07 ` Dave Chinner
@ 2013-08-21 14:28 ` Mark Tinguely
2013-08-21 15:28 ` Eric Sandeen
2013-08-21 17:01 ` Rich Johnston
2 siblings, 1 reply; 6+ messages in thread
From: Mark Tinguely @ 2013-08-21 14:28 UTC (permalink / raw)
To: Eric Sandeen; +Cc: 'linux-xfs@oss.sgi.com'
On 08/20/13 18:14, Eric Sandeen wrote:
> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
>
> un-static'd alloc_ex_data and used it in phase6.c,
> but didn't put a prototype in a header, so:
>
> phase6.c: In function ‘mk_orphanage’:
> phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
>
> Fix it...
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
Thanks and sorry. I knew it and hoped to get it in before it got committed.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
2013-08-21 14:28 ` Mark Tinguely
@ 2013-08-21 15:28 ` Eric Sandeen
2013-08-21 17:14 ` Rich Johnston
0 siblings, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2013-08-21 15:28 UTC (permalink / raw)
To: Mark Tinguely; +Cc: 'linux-xfs@oss.sgi.com', Eric Sandeen
On 8/21/13 9:28 AM, Mark Tinguely wrote:
> On 08/20/13 18:14, Eric Sandeen wrote:
>> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
>>
>> un-static'd alloc_ex_data and used it in phase6.c,
>> but didn't put a prototype in a header, so:
>>
>> phase6.c: In function ‘mk_orphanage’:
>> phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
>>
>> Fix it...
>>
>> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
>> ---
>
>
> Thanks and sorry. I knew it and hoped to get it in before it got committed.
Eh, it happens.
Minor demerit for Rich for not catching it before commit, either ;)
-Eric (who has never, NEVER made a mistake like that)
>
> --Mark.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
2013-08-20 23:14 [PATCH] xfs_repair: add prototype for alloc_ex_data() Eric Sandeen
2013-08-21 0:07 ` Dave Chinner
2013-08-21 14:28 ` Mark Tinguely
@ 2013-08-21 17:01 ` Rich Johnston
2 siblings, 0 replies; 6+ messages in thread
From: Rich Johnston @ 2013-08-21 17:01 UTC (permalink / raw)
To: Eric Sandeen; +Cc: 'linux-xfs@oss.sgi.com', Mark Tinguely
Thanks for the patch Eric. it has been committed.
--Rich
commit 2e1622703bb5c01e5f6d5fa087999c768868aa0b
Author: Eric Sandeen <sandeen@redhat.com>
Date: Tue Aug 20 23:14:17 2013 +0000
xfs_repair: add prototype for alloc_ex_data()
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
2013-08-21 15:28 ` Eric Sandeen
@ 2013-08-21 17:14 ` Rich Johnston
0 siblings, 0 replies; 6+ messages in thread
From: Rich Johnston @ 2013-08-21 17:14 UTC (permalink / raw)
To: Eric Sandeen; +Cc: 'linux-xfs@oss.sgi.com', Eric Sandeen, Mark Tinguely
On 08/21/2013 10:28 AM, Eric Sandeen wrote:
> On 8/21/13 9:28 AM, Mark Tinguely wrote:
>> On 08/20/13 18:14, Eric Sandeen wrote:
>>> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
>>>
>>> un-static'd alloc_ex_data and used it in phase6.c,
>>> but didn't put a prototype in a header, so:
>>>
>>> phase6.c: In function ‘mk_orphanage’:
>>> phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
>>>
>>> Fix it...
>>>
>>> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
>>> ---
>>
>>
>> Thanks and sorry. I knew it and hoped to get it in before it got committed.
>
> Eh, it happens.
>
> Minor demerit for Rich for not catching it before commit, either ;)
***rjohnston: hides head in shame and vows to improve
>
> -Eric (who has never, NEVER made a mistake like that)
>
>>
>> --Mark.
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-21 17:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-20 23:14 [PATCH] xfs_repair: add prototype for alloc_ex_data() Eric Sandeen
2013-08-21 0:07 ` Dave Chinner
2013-08-21 14:28 ` Mark Tinguely
2013-08-21 15:28 ` Eric Sandeen
2013-08-21 17:14 ` Rich Johnston
2013-08-21 17:01 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox