From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 5DF4B7F95 for ; Wed, 21 Aug 2013 01:44:01 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 4738C3040BD for ; Tue, 20 Aug 2013 23:44:01 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by cuda.sgi.com with ESMTP id mOd8eYnnSiTBdecS (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Tue, 20 Aug 2013 23:43:59 -0700 (PDT) Date: Tue, 20 Aug 2013 23:43:57 -0700 From: Christoph Hellwig Subject: Re: [PATCH 1/3] quota: Add a new quotactl command Q_XGETQSTATV Message-ID: <20130821064357.GA8822@infradead.org> References: <1375828029-26360-1-git-send-email-sekharan@us.ibm.com> <1375828029-26360-2-git-send-email-sekharan@us.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1375828029-26360-2-git-send-email-sekharan@us.ibm.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Chandra Seetharaman Cc: linux-fsdevel , Abhijith Das , Jan Kara , Steven Whitehouse , xfs@oss.sgi.com Sorry for being late to the game, but I don not like the in-kernel interface here at all. Given that Q_XGETQSTATV is a strict superset of Q_XGETQSTAT there is no need for the second method - just always fill out the larger in-kernel structure and only copy the smaller information to userspace for the Q_XGETSTAT case. That keeps the amount of code required in the implementations of the methods low and follows the model used elsewhere in the kernel (e.g. stat and statfs) _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs