From: Ben Myers <bpm@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2] xfs: Simplify xfs_ail_min() with list_first_entry_or_null()
Date: Fri, 23 Aug 2013 13:06:30 -0500 [thread overview]
Message-ID: <20130823180630.GU5262@sgi.com> (raw)
In-Reply-To: <520C6253.6080809@oracle.com>
On Thu, Aug 15, 2013 at 01:08:35PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> At xfs_ail_min(), we do check if the AIL list is empty or not before
> returning the first item in it with list_empty() and list_first_entry().
>
> This can be simplified a bit with a new list operation routine that is
> the list_first_entry_or_null() which has been introduced by:
>
> commit 6d7581e62f8be462440d7b22c6361f7c9fa4902b
> list: introduce list_first_entry_or_null
>
> v2: make xfs_ail_min() as a static inline function and move it to
> xfs_trans_priv.h as per Dave Chinner's comments.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Applied. Thanks Jeff.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-08-23 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 5:08 [PATCH v2] xfs: Simplify xfs_ail_min() with list_first_entry_or_null() Jeff Liu
2013-08-23 18:06 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823180630.GU5262@sgi.com \
--to=bpm@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox