From: David Sterba <dsterba@suse.cz>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-btrfs@vger.kernel.org, Josef Bacik <jbacik@fusionio.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V2
Date: Thu, 29 Aug 2013 15:21:58 +0200 [thread overview]
Message-ID: <20130829132158.GI23113@twin.jikos.cz> (raw)
In-Reply-To: <520A8B1D.60307@redhat.com>
On Tue, Aug 13, 2013 at 02:38:05PM -0500, Eric Sandeen wrote:
> > +. ./common/rc
> > +. ./common/filter
> > +
> > +# real QA test starts here
> > +_supported_fs btrfs
> > +_supported_os Linux
> > +_require_scratch
> > +
> > +_scratch_mkfs > /dev/null 2>&1
> > +_scratch_mount
> > +
> > +# This will be set to subvolid 256. If this ever changes in the future for
> > +# whatever reason we'll have to pull the subvolid out of the subvol list command
> > +# but since it's a newly mkfs'ed fs we should be fine with this.
>
> . . . and then you grab it out of the subvol list command anyway ;)
>
> So really this comment should go, and it sure would be nice to have
> a btrfs_get_subvolid() helper for future generations...
This is available in the 'btrfs subvol show /subvol':
# btrfs subvol show subv1
/mnt/a15/subv1
Name: subv1
uuid: cf010ad0-38bf-7a42-88be-3360f68cd335
Parent uuid: e6543f70-5d38-1845-b976-d18095860bdf
Creation time: 2013-08-29 15:18:18
Object ID: 258
Generation (Gen): 6
Gen at creation: 6
Parent: 5
Top Level: 5
Flags: readonly
Snapshot(s):
Though it involves grep as well.
david
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-29 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 19:34 [PATCH] xfstests: btrfs/003: regression test for subvol delete V2 Josef Bacik
2013-08-13 19:38 ` Eric Sandeen
2013-08-29 13:21 ` David Sterba [this message]
2013-08-29 16:14 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829132158.GI23113@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox