From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 0/2 v2] Fix O_SYNC AIO DIO
Date: Fri, 30 Aug 2013 16:53:01 +0100 [thread overview]
Message-ID: <20130830155301.GB13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1376471456-11966-1-git-send-email-jack@suse.cz>
On Wed, Aug 14, 2013 at 11:10:54AM +0200, Jan Kara wrote:
> Hello,
>
> this is second iteration of patches to fix handling of O_SYNC AIO DIO.
> Since previous version I've addressed Dave's comments:
> - slightly expanded changelog of the first patch
> - workqueue is now created with parameters allowing paralelism
> - workqueue name contains sb->s_id
> - workqueue is created on demand (I decided to do this to reduce the overhead
> in unnecessary cases)
>
> The patchset survives xfstests run for ext4 & xfs so it should be sane. Since
> this touches several filesystems (although only ext4 & xfs are non-trivial),
> the question is who should carry these patches. Maybe Al? But since xfs and
> ext4 changes are non-trivial, I'd like to have a review from their
> developers...
Looks sane, except that I'd probably put destroying the queue after
evict_inodes(), next to ->put_super() call.
Said that, there's another interesting problem in the code affected by that
sucker: generic_file_aio_write() might very well sync the wrong range.
Consider O_APPEND case; __generic_file_aio_write() will call
generic_write_checks(), which will update its copy of pos, and proceed to
write starting from there. All right and proper, but then we return into
generic_file_aio_write() and sync the range of the right length, starting
at the *original* value of pos...
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-30 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 9:10 [PATCH 0/2 v2] Fix O_SYNC AIO DIO Jan Kara
2013-08-14 9:10 ` [PATCH 1/2] direct-io: Implement generic deferred AIO completions Jan Kara
2013-08-14 9:10 ` [PATCH 2/2] direct-io: Handle O_(D)SYNC AIO Jan Kara
2013-08-30 15:53 ` Al Viro [this message]
2013-09-04 10:54 ` [PATCH 0/2 v2] Fix O_SYNC AIO DIO Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830155301.GB13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox