From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't account buffer cancellation during log recovery readahead
Date: Fri, 30 Aug 2013 13:38:34 -0500 [thread overview]
Message-ID: <20130830183834.GE1935@sgi.com> (raw)
In-Reply-To: <20130829151324.GB5262@sgi.com>
On Thu, Aug 29, 2013 at 10:13:24AM -0500, Ben Myers wrote:
> On Tue, Aug 27, 2013 at 08:10:53AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > When doing readhaead in log recovery, we check to see if buffers are
> > cancelled before doing readahead. If we find a cancelled buffer,
> > however, we always decrement the reference count we have on it, and
> > that means that readahead is causing a double decrement of the
> > cancelled buffer reference count.
> >
> > This results in log recovery *replaying cancelled buffers* as the
> > actual recovery pass does not find the cancelled buffer entry in the
> > commit phase of the second pass across a transaction. On debug
> > kernels, this results in an ASSERT failure like so:
> >
> > XFS: Assertion failed: !(flags & XFS_BLF_CANCEL), file: fs/xfs/xfs_log_recover.c, line: 1815
> >
> > xfstests generic/311 reproduces this ASSERT failure with 100%
> > reproducability.
> >
> > Fix it by making readahead only peek at the buffer cancelled state
> > rather than the full accounting that xlog_check_buffer_cancelled()
> > does.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Nice work Dave!
> Reviewed-by: Ben Myers <bpm@sgi.com>
Applied this one.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-08-30 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 22:10 [PATCH] xfs: don't account buffer cancellation during log recovery readahead Dave Chinner
2013-08-29 15:13 ` Ben Myers
2013-08-30 18:38 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830183834.GE1935@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox