From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: ensure we copy buffer type in da btree root splits
Date: Mon, 2 Sep 2013 01:17:25 -0700 [thread overview]
Message-ID: <20130902081725.GB11210@infradead.org> (raw)
In-Reply-To: <1378081921-18570-3-git-send-email-david@fromorbit.com>
On Mon, Sep 02, 2013 at 10:32:01AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> When splitting the root of the da btree, we shuffled data between
> buffers and the structures that track them. At one point, we copy
> data and state from one buffer to another, including the ops
> aasociated with the buffer. When we do this, we also need to copy
> the buffer type associated with the buf log item so that the buffer
> is logged correctly. If we don't do that, log recovery won't
> recognise it and hence it won't recalculate the CRC on the buffer
> after recovery. This leads to a directory block that can't be read
> after recovery has run.
>
> Found by inspection after finding the same problem with remote
> symlink buffers.
It would be great to find a way to trigger this in QA as this shows
another area lacking coverage.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-02 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 0:31 [PATCH 0/2] xfs: log recovery buffer fixes Dave Chinner
2013-09-02 0:32 ` [PATCH 1/2] xfs: set remote symlink buffer type for recovery Dave Chinner
2013-09-02 8:16 ` Christoph Hellwig
2013-09-02 10:05 ` Dave Chinner
2013-09-02 0:32 ` [PATCH 2/2] xfs: ensure we copy buffer type in da btree root splits Dave Chinner
2013-09-02 8:17 ` Christoph Hellwig [this message]
2013-09-02 10:09 ` Dave Chinner
2013-09-10 22:41 ` [PATCH 0/2] xfs: log recovery buffer fixes Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902081725.GB11210@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox