From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 14F9A7F55 for ; Mon, 2 Sep 2013 03:19:57 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 94A95AC002 for ; Mon, 2 Sep 2013 01:19:56 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by cuda.sgi.com with ESMTP id r66SyCIzq5InhfqQ (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 02 Sep 2013 01:19:55 -0700 (PDT) Date: Mon, 2 Sep 2013 01:19:54 -0700 From: Christoph Hellwig Subject: Re: [PATCH 2/2] xfs: fix some minor sparse warnings Message-ID: <20130902081954.GD11210@infradead.org> References: <1378092179-24973-1-git-send-email-david@fromorbit.com> <1378092179-24973-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1378092179-24973-3-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com > --- a/fs/xfs/xfs_dquot_item.c > +++ b/fs/xfs/xfs_dquot_item.c > @@ -143,6 +143,8 @@ STATIC uint > xfs_qm_dquot_logitem_push( > struct xfs_log_item *lip, > struct list_head *buffer_list) > + __releases(&lip->li_ailp->xa_lock) > + __acquires(&lip->li_ailp->xa_lock) > { Having these markers indented the same amount as the parameters isn't very readable. Maybe give them another tab level? Otherwise looks good: Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs