From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/2] xfs: more shutdown-related fixes
Date: Tue, 3 Sep 2013 12:02:10 -0700 [thread overview]
Message-ID: <20130903190210.GA23072@infradead.org> (raw)
In-Reply-To: <1378208858-20557-1-git-send-email-david@fromorbit.com>
On Tue, Sep 03, 2013 at 09:47:36PM +1000, Dave Chinner wrote:
> Hi folks,
>
> More fixes as a result of forced shutdown testing. The first is
> fixing yet another hole in the buf log item freein logic when a
> transaction is aborted, and the other removes the asserts from the
> inode buffer checking so that verifiers return errors rather than
> crashing the system.
Btw, I've been wondering for a while if we need a major change to how
the buf item refcounting works. All these little special cases in there
are utterly non-intuitive. I've not looked very deep yet, but a normal
scheme where every reference to it increments the refcount, and we
simply free it when that hits zero should work here as well. We'd
still need flags for the abort and clean conditions, but it would still
be way simpler than what we have now.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-03 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 11:47 [PATCH 0/2] xfs: more shutdown-related fixes Dave Chinner
2013-09-03 11:47 ` [PATCH 1/2] xfs: aborted buf items can be in the AIL Dave Chinner
2013-09-06 19:39 ` Mark Tinguely
2013-09-03 11:47 ` [PATCH 2/2] xfs: don't assert fail on bad inode numbers Dave Chinner
2013-09-06 19:54 ` Mark Tinguely
2013-10-18 16:51 ` Rich Johnston
2013-09-03 19:02 ` Christoph Hellwig [this message]
2013-09-03 19:56 ` [PATCH 0/2] xfs: more shutdown-related fixes Dave Chinner
2013-09-10 22:39 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903190210.GA23072@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox