From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH V2] xfs: dtype changed xfs_dir2_sfe_put_ino to xfs_dir3_sfe_put_ino
Date: Tue, 3 Sep 2013 14:35:41 -0500 [thread overview]
Message-ID: <20130903193541.GM1935@sgi.com> (raw)
In-Reply-To: <20130902021559.GC23571@dastard>
Hi Dave,
On Mon, Sep 02, 2013 at 12:15:59PM +1000, Dave Chinner wrote:
> On Fri, Aug 30, 2013 at 04:21:20PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > So fix up the export in xfs_dir2.h that is needed by userspace.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Well, this patch now causes a compilation failure. Why?
> xfs_dir3_sfe_put_ino() got marked as static because it didn't have a
> matching export.
>
> Perhaps we should be a little less hasty in merging auto-generated
> patches from random build-farms? The patch was wrong - fixing the
> prototype like in v1 of this patch was the correct thing to do....
>
> So, the updated patch below adds the revert.
>
> Cheers,
>
> Dave.
>
> PS: Ben, when you merge a patch from a reply in an email thread,
> can you please pull the commit subject line from the patch, not the
> title of the email thread? One of the recent commits got it wrong.
> i.e. commit 3780437
>
> "XFS: Assertion failed: first <= last && last < BBTOB(bp->b_length), file:"
>
> should have had the title
>
> "xfs: fix calculation of the number of node entries in a dir3 node"
I'll keep an eye out, thanks.
> --
> Dave Chinner
> david@fromorbit.com
>
> xfs: dtype changed xfs_dir2_sfe_put_ino to xfs_dir3_sfe_put_ino
>
> From: Dave Chinner <dchinner@redhat.com>
>
> So fix up the export in xfs_dir2.h that is needed by userspace.
>
> <sigh>
>
> Now xfs_dir3_sfe_put_ino has been made static. Revert 98f7462 ("xfs:
> xfs_dir3_sfe_put_ino can be static") to being non static so that the
> code shared with userspace is identical again.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Ah.. sorry I missed that it's used in your userspace series. Could you repost
your userspace series soon?
Reviewed-by: Ben Myers <bpm@sgi.com>
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-03 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 6:21 [PATCH 0/2] xfs: minor cleanups for userspace sanity Dave Chinner
2013-08-30 6:21 ` [PATCH 1/2] xfs: dtype changed xfs_dir2_sfe_put_ino to xfs_dir3_sfe_put_ino Dave Chinner
2013-08-30 13:56 ` Mark Tinguely
2013-09-02 2:15 ` [PATCH V2] " Dave Chinner
2013-09-03 19:35 ` Ben Myers [this message]
2013-08-30 6:21 ` [PATCH 2/2] xfs: XFS_MOUNT_QUOTA_ALL needed by userspace Dave Chinner
2013-08-30 13:58 ` Mark Tinguely
2013-09-03 22:21 ` [PATCH 0/2] xfs: minor cleanups for userspace sanity Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903193541.GM1935@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox