From: Dave Chinner <david@fromorbit.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix device lookup in btrfs/003
Date: Thu, 5 Sep 2013 09:24:12 +1000 [thread overview]
Message-ID: <20130904232412.GM23571@dastard> (raw)
In-Reply-To: <52266055.9050004@suse.com>
Add xfs@oss.sgi.com to the cc list.
On Tue, Sep 03, 2013 at 06:19:01PM -0400, Jeff Mahoney wrote:
> The DEVHTL lookup in btrfs/003 is broken. It can only handle full LUNs and
> not partitions on a disk.
>
> Rather than returning 2:0:0:0 for /dev/sdc7, it returns 'block' and we see:
> ./common/rc: line 2081: /sys/class/scsi_device/block/device/delete:
> No such file or directory
>
> If we look up the device by dev instead of by name, we can handle working
> with full disks and partitions more easily and get the ability to use
> any device name rather than just the ones that match sysfs.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
> tests/btrfs/003 | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> --- a/tests/btrfs/003
> +++ b/tests/btrfs/003
> @@ -137,9 +137,21 @@ _test_replace()
> #pick the 2nd last disk
> ds=${devs[@]:$(($n-1)):1}
>
> - # retrive the HTL for this scsi disk
> - d=`echo $ds|cut -d"/" -f3`
> - DEVHTL=`ls -l /sys/class/block/${d} | rev | cut -d "/" -f 3 | rev`
> + HEXMAJOR="$(stat -c "%t" "$ds")"
> + HEXMINOR="$(stat -c "%T" "$ds")"
> + if [ -z "$HEXMAJOR" -o -z "$HEXMINOR" ]; then
> + _fail "tr: HEXMAJOR and/or HEXMINOR is unset for $ds"
> + fi
> +
> + DIR="/sys/dev/block/$(( 0x$HEXMAJOR )):$(( 0x$HEXMINOR ))"
> +
> + if [ -L "$DIR/device" ]; then # whole disk
> + DEVHTL="$(basename $(readlink "$DIR/device"))"
> + elif [ -L "$DIR/../device" ]; then # partition
> + DEVHTL="$(basename $(readlink "$DIR/../device"))"
> + else
> + _fail "tr: Can't locate device backing $ds"
> + fi
>
> #fail disk
> _devmgt_remove ${DEVHTL}
>
> --
> Jeff Mahoney
> SUSE Labs
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next parent reply other threads:[~2013-09-04 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52266055.9050004@suse.com>
2013-09-04 23:24 ` Dave Chinner [this message]
2013-09-06 14:03 ` [PATCH] xfstests: fix device lookup in btrfs/003 David Sterba
2013-09-06 14:41 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904232412.GM23571@dastard \
--to=david@fromorbit.com \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox