From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>,
Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH, RFC] xfs: don't break from growfs ag update loop on error
Date: Tue, 10 Sep 2013 08:08:24 +1000 [thread overview]
Message-ID: <20130909220824.GV12779@dastard> (raw)
In-Reply-To: <522E3142.7090501@sandeen.net>
On Mon, Sep 09, 2013 at 03:36:18PM -0500, Eric Sandeen wrote:
> On 8/15/13 1:15 PM, Eric Sandeen wrote:
> > When xfs_growfs_data_private() is updating backup superblocks,
> > it bails out on the first error encountered, whether reading or
> > writing:
>
> Any thoughts on this one? W/ the verifiers, we have a higher
> chance of encountering an error, and leaving the rest of the
> supers un-updated. Repair will then possibly revert the fs to
> it's pre-growfs state, and data loss will ensue...
Sorry, I must have missed this. I remember discussing it with you.
The change looks fine to me, but I haven't tested it at all.
Acked-by: Dave Chinner <david@fromorbit.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-09 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 18:15 [PATCH, RFC] xfs: don't break from growfs ag update loop on error Eric Sandeen
2013-09-09 20:36 ` Eric Sandeen
2013-09-09 22:08 ` Dave Chinner [this message]
2013-09-10 15:21 ` Mark Tinguely
2013-09-10 15:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909220824.GV12779@dastard \
--to=david@fromorbit.com \
--cc=linux-xfs@oss.sgi.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox