From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 165897F37 for ; Wed, 11 Sep 2013 17:29:55 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id D6EAF304048 for ; Wed, 11 Sep 2013 15:29:54 -0700 (PDT) Date: Wed, 11 Sep 2013 12:07:25 +1000 From: Dave Chinner Subject: Re: [patch] xfs: = vs == typo in ASSERT() Message-ID: <20130911020725.GE2445@devil.localdomain> References: <20130911211731.GA10527@elgon.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130911211731.GA10527@elgon.mountain> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dan Carpenter Cc: Ben Myers , Alex Elder , kernel-janitors@vger.kernel.org, xfs@oss.sgi.com On Thu, Sep 12, 2013 at 12:17:31AM +0300, Dan Carpenter wrote: > There is a '=' vs '==' typo so the ASSERT()s are always true. > > Signed-off-by: Dan Carpenter > --- > Introduced in 21b5c9784b ('xfs: swap extents operations for CRC > filesystems') > > diff --git a/fs/xfs/xfs_bmap_btree.c b/fs/xfs/xfs_bmap_btree.c > index 531b020..bb8de8e 100644 > --- a/fs/xfs/xfs_bmap_btree.c > +++ b/fs/xfs/xfs_bmap_btree.c > @@ -957,9 +957,9 @@ xfs_bmbt_change_owner( > ASSERT(tp || buffer_list); > ASSERT(!(tp && buffer_list)); > if (whichfork == XFS_DATA_FORK) > - ASSERT(ip->i_d.di_format = XFS_DINODE_FMT_BTREE); > + ASSERT(ip->i_d.di_format == XFS_DINODE_FMT_BTREE); > else > - ASSERT(ip->i_d.di_aformat = XFS_DINODE_FMT_BTREE); > + ASSERT(ip->i_d.di_aformat == XFS_DINODE_FMT_BTREE); > Eek! Well, actually, it's harmless, because the only callers of that function do so after checking that ip->i_d.di_format == XFS_DINODE_FMT_BTREE. So, the fix is definitely needed, but it's not as bad as it looks. Reviewed-by: Dave Chinner Thanks, Dan. Cheers, Dave. -- Dave Chinner dchinner@redhat.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs