From: Dave Chinner <dchinner@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: mtinguely@sgi.com, xfs@oss.sgi.com
Subject: Re: xfs: recovery of swap extents operations for CRC filesystems
Date: Wed, 11 Sep 2013 12:19:29 +1000 [thread overview]
Message-ID: <20130911021929.GF2445@devil.localdomain> (raw)
In-Reply-To: <20130911211819.GB10527@elgon.mountain>
On Thu, Sep 12, 2013 at 12:18:19AM +0300, Dan Carpenter wrote:
> Hello Dave Chinner,
>
> The patch 638f44163d57: "xfs: recovery of swap extents operations for
> CRC filesystems" from Aug 30, 2013, leads to the following
> static checker warning: "fs/xfs/xfs_log_recover.c:2999
> xlog_recover_inode_pass2()
> info: ignoring unreachable code."
>
> fs/xfs/xfs_log_recover.c
> 2992 out_release:
> 2993 xfs_buf_relse(bp);
> 2994 error:
> 2995 if (need_free)
> 2996 kmem_free(in_f);
> 2997 return XFS_ERROR(error);
> ^^^^^^^^^^^^^^^^^^^^^^^
> 2998
> 2999 xfs_buf_relse(bp);
> 3000 goto error;
>
> These two added lines are unreachable. Sometimes people add dead code
> for later, so this might be intentional. It's not clear.
It's dead code. I reworked the error handling of the function and
didn't clean up all the mess.
Mark, I'm away from my upstream dev environment until next week -
can you send a followup patch to fix this?
Cheers,
Dave.
--
Dave Chinner
dchinner@redhat.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-11 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 21:18 xfs: recovery of swap extents operations for CRC filesystems Dan Carpenter
2013-09-11 2:19 ` Dave Chinner [this message]
2013-09-11 22:44 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911021929.GF2445@devil.localdomain \
--to=dchinner@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=mtinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox