re: xfs: recovery of swap extents operations for CRC filesystems

re: xfs: recovery of swap extents operations for CRC filesystems

[Dan Carpenter]

Hello Dave Chinner,

The patch 638f44163d57: "xfs: recovery of swap extents operations for
CRC filesystems" from Aug 30, 2013, leads to the following
static checker warning: "fs/xfs/xfs_log_recover.c:2999
xlog_recover_inode_pass2()
	 info: ignoring unreachable code."

fs/xfs/xfs_log_recover.c
  2992  out_release:
  2993          xfs_buf_relse(bp);
  2994  error:
  2995          if (need_free)
  2996                  kmem_free(in_f);
  2997          return XFS_ERROR(error);
                ^^^^^^^^^^^^^^^^^^^^^^^
  2998  
  2999          xfs_buf_relse(bp);
  3000          goto error;

These two added lines are unreachable.  Sometimes people add dead code
for later, so this might be intentional.  It's not clear.

  3001  }

regards,
dan carpenter

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfs: recovery of swap extents operations for CRC filesystems

[Dave Chinner]

On Thu, Sep 12, 2013 at 12:18:19AM +0300, Dan Carpenter wrote:
> Hello Dave Chinner,
> 
> The patch 638f44163d57: "xfs: recovery of swap extents operations for
> CRC filesystems" from Aug 30, 2013, leads to the following
> static checker warning: "fs/xfs/xfs_log_recover.c:2999
> xlog_recover_inode_pass2()
> 	 info: ignoring unreachable code."
> 
> fs/xfs/xfs_log_recover.c
>   2992  out_release:
>   2993          xfs_buf_relse(bp);
>   2994  error:
>   2995          if (need_free)
>   2996                  kmem_free(in_f);
>   2997          return XFS_ERROR(error);
>                 ^^^^^^^^^^^^^^^^^^^^^^^
>   2998  
>   2999          xfs_buf_relse(bp);
>   3000          goto error;
> 
> These two added lines are unreachable.  Sometimes people add dead code
> for later, so this might be intentional.  It's not clear.

It's dead code. I reworked the error handling of the function and
didn't clean up all the mess.

Mark, I'm away from my upstream dev environment until next week -
can you send a followup patch to fix this?

Cheers,

Dave.
-- 
Dave Chinner
dchinner@redhat.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfs: recovery of swap extents operations for CRC filesystems

[Mark Tinguely]

On 09/10/13 21:19, Dave Chinner wrote:
> On Thu, Sep 12, 2013 at 12:18:19AM +0300, Dan Carpenter wrote:
>> Hello Dave Chinner,
>>
>> The patch 638f44163d57: "xfs: recovery of swap extents operations for
>> CRC filesystems" from Aug 30, 2013, leads to the following
>> static checker warning: "fs/xfs/xfs_log_recover.c:2999
>> xlog_recover_inode_pass2()
>> 	 info: ignoring unreachable code."
>>
>> fs/xfs/xfs_log_recover.c
>>    2992  out_release:
>>    2993          xfs_buf_relse(bp);
>>    2994  error:
>>    2995          if (need_free)
>>    2996                  kmem_free(in_f);
>>    2997          return XFS_ERROR(error);
>>                  ^^^^^^^^^^^^^^^^^^^^^^^
>>    2998
>>    2999          xfs_buf_relse(bp);
>>    3000          goto error;
>>
>> These two added lines are unreachable.  Sometimes people add dead code
>> for later, so this might be intentional.  It's not clear.
>
> It's dead code. I reworked the error handling of the function and
> didn't clean up all the mess.
>
> Mark, I'm away from my upstream dev environment until next week -
> can you send a followup patch to fix this?
>
> Cheers,
>
> Dave.

sure. I should have caught it in review.

--Mark.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs