public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] [RFC] xfs: increase inode cluster size for v5 filesystems
Date: Wed, 11 Sep 2013 09:21:59 -0700	[thread overview]
Message-ID: <20130911162159.GA29319@infradead.org> (raw)
In-Reply-To: <20130909153546.GT12779@dastard>

On Tue, Sep 10, 2013 at 01:35:47AM +1000, Dave Chinner wrote:
> The test matrix of having to test everything on v4 and v5 is just
> nasty, especially if we are talking about prototyping code. I'd much
> prefer to bring things to v5 filesytsems where we have much lower
> exposure and risk of corruption problems, and then when we know it's
> solid because of the QA we've done on it, then we can expose the
> majority of the XFS userbase to it by bringing it back to v4
> filesystems.

I think the test matrix is a reason for not enabling this only on v5
filesystems.  Large inodes are an old and supported use case, although
probably not as heavily tested as it should.  By introducing two
different large inode cases we don't really help increasing test
coverage for a code path that is the same for v4 and v5.

That being said as long as you're still prototyping I'm not going to
interfere.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-09-11 16:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09  8:34 [PATCH] [RFC] xfs: increase inode cluster size for v5 filesystems Dave Chinner
2013-09-09 13:32 ` Christoph Hellwig
2013-09-09 13:54   ` Eric Sandeen
2013-09-09 15:35   ` Dave Chinner
2013-09-11 16:21     ` Christoph Hellwig [this message]
2013-09-17  1:04       ` Dave Chinner
2013-09-17 13:51         ` Mark Tinguely
2013-09-17 21:25           ` Dave Chinner
2013-09-17 14:46         ` Eric Sandeen
2013-09-17 21:11           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130911162159.GA29319@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox