From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 6EE4F7F37 for ; Sat, 14 Sep 2013 22:27:35 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id ED49CAC001 for ; Sat, 14 Sep 2013 20:27:31 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id B5sG1Vn1Pyn36fLz for ; Sat, 14 Sep 2013 20:27:21 -0700 (PDT) Date: Sun, 15 Sep 2013 13:27:18 +1000 From: Dave Chinner Subject: Re: [PATCH 31/55 V3] libxfs: switch over to xfs_sb.c and remove xfs_mount.c Message-ID: <20130915032718.GJ12541@dastard> References: <1378332359-14737-1-git-send-email-david@fromorbit.com> <1378332359-14737-32-git-send-email-david@fromorbit.com> <522A1BCA.6010500@sgi.com> <20130906214021.GD12541@dastard> <522A4C79.1030200@sgi.com> <20130910010241.GZ12779@dastard> <522F289E.6070802@sgi.com> <20130910213249.GC19103@dastard> <52306F3E.8060409@sgi.com> <52307D39.6060903@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52307D39.6060903@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Mark Tinguely Cc: xfs@oss.sgi.com On Wed, Sep 11, 2013 at 09:24:57AM -0500, Mark Tinguely wrote: > On 09/11/13 08:25, Mark Tinguely wrote: > >On 09/10/13 16:32, Dave Chinner wrote: > > > > > libxfs: switch over to xfs_sb.c and remove xfs_mount.c > > > > > > From: Dave Chinner > > > > > > Now that the kernel code has split the superblock specific code out > > > of xfs_mount.c, we don't need xfs_mount.c anymore. Copy in xfs_sb.c > > > and remove xfs_mount.c > > > > > > Signed-off-by: Dave Chinner > > > --- > > > >Applies clean for me. > > > >Reviewed-by: Mark Tinguely > > patch 31 V2/V3 break the compilation of xfsprogs. > > I get: > ... > > configure: creating ./config.status > config.status: creating include/builddefs > config.status: creating include/platform_defs.h > config.status: executing libtool commands > Building include > [LN] xfs > [LN] disk > Building libxfs > [CC] gen_crc32table > [GENERATE] crc32table.h > [TEST] CRC32 > CRC_LE_BITS = 32 > crc32: tests passed, 225944 bytes in 117 usec > crc32c: tests passed, 225944 bytes in 121 usec > gmake[3]: *** No rule to make target `.ltdep', needed by `ltdepend'. Stop. > gmake[2]: *** [libxfs] Error 2 > make[1]: *** [default] Error 2 > make: *** [default] Error 2 That's a dependency build problem because the dependencies changed and weren't rebuilt. make distclean and start again, and the dependencies will get rebuilt correctly. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs