Re: [PATCH, RFC] xfstests: add d_type checking to fsstress

Mark Tinguely
2013-09-16T22:22:13Z

On 09/16/13 16:55, Eric Sandeen wrote:
> This patch adds a "-D" switch to fsstress so that every time
> we call readdir, we stat the dentry& compare it's st_mode
> to the d_type.
>
> If -D is specified only once, it ignores DT_UNKNOWN. If specified
> twice, it considers DT_UNKNOWN to be an error.
>
> It skips paths of "./." and "./.." so that we only look at files
> newly created within the filesystem.
>
> This could be used in an xfstest; it's noisy on a failures so
> would break expected output.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> fsstress doesn't usually do validation, but it's such a handy
> framework for creating a ton of random files, this seems like
> an ok place to put it. What do folks think?

I tried v5 and v4 with and without inode fields in the directory.
This looks good to me. Like the 2 levels of the test.

--Mark.