From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Mark Tinguely <tinguely@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: initialize filetype for lost+found creation
Date: Thu, 19 Sep 2013 07:17:53 +1000 [thread overview]
Message-ID: <20130918211753.GC4330@dastard> (raw)
In-Reply-To: <523A156A.5040502@sandeen.net>
On Wed, Sep 18, 2013 at 04:04:42PM -0500, Eric Sandeen wrote:
> On 9/18/13 3:55 PM, Mark Tinguely wrote:
> > On 09/17/13 12:07, Eric Sandeen wrote:
> >> If we create lost+found make sure it's got the proper filetype.
> >>
> >> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> >> ---
> >>
> >> (sorry, untested, not sure how to force creation when I can't use
> >> xfs_db to craft a filesystem that needs lost+found)
> >
> > The {lib}xfs_dir_lookup() doesn't use the field - just like extended attributes use xfs_names but it won't use the field entry, but it does not hurt to have it initialized to something.
>
> Thanks for the review - just FWIW, I was thinking that it needs
> to be initialized so that when created, it is created with the proper
> type, rather than random stack noise.
>
> It seems, though, that we're still missing bits in libxfs to actually
> write the types to disk; I'll look into that.
Patch below.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
libxfs: fix missing filetype updates to xfs_dir2.c
From: Dave Chinner <dchinner@redhat.com>
They were missed in the original patch that was committed.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
libxfs/xfs_dir2.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libxfs/xfs_dir2.c b/libxfs/xfs_dir2.c
index 010c701..96a3c1d 100644
--- a/libxfs/xfs_dir2.c
+++ b/libxfs/xfs_dir2.c
@@ -194,6 +194,7 @@ xfs_dir_createname(
memset(&args, 0, sizeof(xfs_da_args_t));
args.name = name->name;
args.namelen = name->len;
+ args.filetype = name->type;
args.hashval = dp->i_mount->m_dirnameops->hashname(name);
args.inumber = inum;
args.dp = dp;
@@ -268,6 +269,7 @@ xfs_dir_lookup(
memset(&args, 0, sizeof(xfs_da_args_t));
args.name = name->name;
args.namelen = name->len;
+ args.filetype = name->type;
args.hashval = dp->i_mount->m_dirnameops->hashname(name);
args.dp = dp;
args.whichfork = XFS_DATA_FORK;
@@ -323,6 +325,7 @@ xfs_dir_removename(
memset(&args, 0, sizeof(xfs_da_args_t));
args.name = name->name;
args.namelen = name->len;
+ args.filetype = name->type;
args.hashval = dp->i_mount->m_dirnameops->hashname(name);
args.inumber = ino;
args.dp = dp;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-18 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 17:07 [PATCH] xfsprogs: initialize filetype for lost+found creation Eric Sandeen
2013-09-18 20:55 ` Mark Tinguely
2013-09-18 21:04 ` Eric Sandeen
2013-09-18 21:17 ` Dave Chinner [this message]
2013-10-18 17:45 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918211753.GC4330@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox