From: Josef Bacik <jbacik@fusionio.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-btrfs@vger.kernel.org, Josef Bacik <jbacik@fusionio.com>,
xfs@oss.sgi.com
Subject: Re: [BULK] Re: [PATCH] xfstests: introduce _filter_backtick
Date: Thu, 19 Sep 2013 09:36:47 -0400 [thread overview]
Message-ID: <20130919133647.GB1615@localhost.localdomain> (raw)
In-Reply-To: <20130918211325.GB4330@dastard>
On Thu, Sep 19, 2013 at 07:13:25AM +1000, Dave Chinner wrote:
> On Wed, Sep 18, 2013 at 04:29:26PM -0400, Josef Bacik wrote:
> > Apparently the GNU guys decided to change their error output from something like
> >
> > Error `Error message'
> >
> > To
> >
> > Error 'Error message'
> >
> > So to fix this I've introduced _filter_backtick which will change any ` to ' and
> > then changed the output of the tests that were failing for me because of this
> > output. I tested this on a new box that has the new output and an old box which
> > has the old output and it appears to fix the issue. Thanks,
> >
> > Signed-off-by: Josef Bacik <jbacik@fusionio.com>
>
> That's just leaving a landmine behind, and it doesn't catch all the
> tests that need updating. This approach was floated here:
>
> http://oss.sgi.com/archives/xfs/2013-05/msg00312.html
>
> And my response was to add a global filter to the .check file so it
> doesn't leave a landmine. Indeed, I have a local version on tomas'
> patch that I modified in May does just that:
>
> --- a/check
> +++ b/check
> @@ -477,6 +477,10 @@ do
> echo " - no qualified output"
> err=true
> else
> +
> + # coreutils 2.16+ changed quote formats in error messages from
> + # `foo' to 'foo'. Filter old versions to match the new version.
> + sed -i "s/\`/\'/g" $tmp.out
> if diff $seq.out $tmp.out >/dev/null 2>&1
> then
> if $err
>
> I also discovered that for some reason LANG=C is not sufficient for
> all cases to make the quoting behaviour consistent. i.e. I
> needed to set LC_ALL=C so that it didn't use weird UTF-8 encodings
> for the quotes instead of a simple backtick.
>
> Full patch below.
Excellent, what is holding this patch up then if it was proposed in May and you
are ok with it? Thanks,
Josef
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-19 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 20:29 [PATCH] xfstests: introduce _filter_backtick Josef Bacik
2013-09-18 21:13 ` Dave Chinner
2013-09-19 13:36 ` Josef Bacik [this message]
2013-09-19 16:20 ` [PATCH] xfstests: unify apostrophes in output files Eric Sandeen
2013-09-19 16:54 ` Ilya Dryomov
2013-09-19 17:03 ` Eric Sandeen
2013-10-16 20:06 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919133647.GB1615@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=david@fromorbit.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox