Re: [PATCH 2/3] xfsprog: add dirent filetype information for xfs_info

Dave Chinner
2013-09-19T22:54:38Z

On Thu, Sep 19, 2013 at 04:05:25PM -0500, Mark Tinguely wrote:
> Make xfs_info aware of the directory inode type.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
> ---
> growfs/xfs_growfs.c | 14 +++++++++-----
> include/xfs_fs.h | 31 ++++++++++++++++---------------
> 2 files changed, 25 insertions(+), 20 deletions(-)
>
> Index: b/growfs/xfs_growfs.c
> ===================================================================
> --- a/growfs/xfs_growfs.c
> +++ b/growfs/xfs_growfs.c
> @@ -55,7 +55,8 @@ report_info(
> int attrversion,
> int projid32bit,
> int crcs_enabled,
> - int cimode)
> + int cimode,
> + int ftype_enabled)
> {
> printf(_(
> "meta-data=%-22s isize=%-6u agcount=%u, agsize=%u blks\n"
> @@ -63,7 +64,7 @@ report_info(
> " =%-22s crc=%u\n"
> "data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n"
> " =%-22s sunit=%-6u swidth=%u blks\n"
> - "naming =version %-14u bsize=%-6u ascii-ci=%d\n"
> + "naming =version %-14u bsize=%-6u ascii-ci=%d field=%d\n"

What does "field" mean? It doesn't describe the feature at all.
"dtype" or "ftype" would be a better description of what is
different in the directory structure...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com