Re: [PATCH 3/3] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field

Mark Tinguely
2013-10-17T13:26:07Z

On 10/16/13 18:50, Dave Chinner wrote:
> On Wed, Oct 16, 2013 at 05:36:57PM -0500, Mark Tinguely wrote:
>> Add directory inode type feature to mkfs.xfs and its manual page.
>>
>> In sb v4, "mkfs.xfs -n ftype=1" turns on the feature. The feature is
>> still automatically turned on for sb v5. Reject the "ftype=1" request
>> if used with the "crc=1" setting.
>>
>> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
>> ---

>> +
>> sbp->sb_features2 = XFS_SB_VERSION2_MKFS(crcs_enabled, lazy_sb_counters,
>> - attrversion == 2, !projid16bit, 0);
>> + attrversion == 2, !projid16bit, 0,
>> + (crcs_enabled && dirftype));

Eek that change was made yesterday and should be:
(!crcs_enabled && dirftype)
so the feature bit is only turned on for v4 sb.

--Mark.