From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 90E3A29DFB for ; Sat, 21 Sep 2013 16:17:47 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 530D48F804B for ; Sat, 21 Sep 2013 14:17:44 -0700 (PDT) Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) by cuda.sgi.com with ESMTP id 5G9njxVYUgoO0Ct0 (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Sat, 21 Sep 2013 14:17:39 -0700 (PDT) Received: by mail-qc0-f181.google.com with SMTP id q4so1123721qcx.26 for ; Sat, 21 Sep 2013 14:17:39 -0700 (PDT) Date: Sat, 21 Sep 2013 17:17:35 -0400 From: Eric Whitney Subject: [PATCH] xfstests: set umask to avoid spurious generic/314 test failures Message-ID: <20130921211735.GC7855@wallace> MIME-Version: 1.0 Content-Disposition: inline List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com Cc: linux-ext4@vger.kernel.org Generic/314 can fail when the group write file mode bit for "subdir" does not match that found in the golden output, as has been seen in ext4 regression testing. It appears that the golden output for generic/314 was taken on a system where the $qa_user's umask cleared that mode bit - most likely, where the umask was 022. Depending upon the distro, it's not uncommon for a user's default umask to have a different value, such as 002. When that's the case, we get a false negative failure when the group write mode bit for "subdir" is not cleared. This failure is unrelated to the value of the SGID mode bit that is the object of this test. We could either require that $qa_user's account be configured in advance with a umask of 022, or explicitly set a umask value compatible with the golden output when creating "subdir". The latter option is more robust. Signed-off-by: Eric Whitney --- tests/generic/314 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 tests/generic/314 diff --git a/tests/generic/314 b/tests/generic/314 old mode 100644 new mode 100755 index 0dd98a3..f430b82 --- a/tests/generic/314 +++ b/tests/generic/314 @@ -57,7 +57,7 @@ chown $qa_user:12345 $TEST_DIR/$seq-dir chmod 2775 $TEST_DIR/$seq-dir # Make subdirs before & after acl set -su $qa_user -c "mkdir $TEST_DIR/$seq-dir/subdir" +su $qa_user -c "umask 022; mkdir $TEST_DIR/$seq-dir/subdir" su $qa_user -c "setfacl -m u:$qa_user:rwx,d:u:$qa_user:rwx $TEST_DIR/$seq-dir" su $qa_user -c "mkdir $TEST_DIR/$seq-dir/subdir2" -- 1.8.1.2 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs