From: Eric Whitney <enwlinux@gmail.com>
To: xfs@oss.sgi.com
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH V2] xfstests: only run generic/300 on filesystems supporting fallocate()
Date: Sat, 21 Sep 2013 18:02:47 -0400 [thread overview]
Message-ID: <20130921220247.GE7855@wallace> (raw)
Generic/300 fails when run on a test filesystem that does not support
fallocate(), as in the case of an ext4 filesystem created without the
extent feature or with the bigalloc feature. It uses fio's falloc
ioengine to generate part of its I/O load, and both fallocates blocks
and punches holes.
Verify that the test filesystem supports fallocate() before proceeding
with the test, checking for both block allocation and hole punching
capabilities. We need to use both _require_xfs_io_falloc and
_require_xfs_io_falloc_punch because the latter does not currently
test for block allocation support. Also, delete any pre-existing test
output to avoid confusion with old results.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
tests/generic/300 | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tests/generic/300 b/tests/generic/300
index 7c60728..1bb2837 100755
--- a/tests/generic/300
+++ b/tests/generic/300
@@ -44,6 +44,17 @@ _supported_os Linux
_need_to_be_root
_require_scratch
+# For this test, the test system's glibc and kernel and the test file system
+# must support both fallocating and hole punching. We don't need xfs_io to
+# perform the test, but we can use it to verify these preconditions. For now,
+# this allows us to avoid duplicating the following functions for fio or other
+# applications that might be used to generate I/O at the cost of picking up a
+# minor dependency on xfsprogs.
+_require_xfs_io_falloc
+_require_xfs_io_falloc_punch
+
+rm -f $seqres.full
+
NUM_JOBS=$((4*LOAD_FACTOR))
BLK_DEV_SIZE=`blockdev --getsz $SCRATCH_DEV`
if [ $((BLK_DEV_SIZE)) -gt 1048576 ]
--
1.8.1.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
reply other threads:[~2013-09-21 22:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130921220247.GE7855@wallace \
--to=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox