From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: v2 xfs directory unbalance assert test
Date: Tue, 24 Sep 2013 09:30:12 +1000 [thread overview]
Message-ID: <20130923233012.GV9901@dastard> (raw)
In-Reply-To: <20130917192538.230164044@sgi.com>
On Tue, Sep 17, 2013 at 02:25:23PM -0500, Mark Tinguely wrote:
> This tests triggers an assert in the XFS directory unbalance code.
> This test originally written by Brian Foster and suggestions
> from Micheal Semon.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
A recent comment about the _cleanup funtion being removed made me
look at this again....
Where's the trap function to catch a ctrl-c and clean up the test
when that happens?
i.e. at minimum, the trap and cleanup function is used to ensure the
test is marked as failed if it is interrupted, and in this case it
probably needs to kill all the fsstress processes and wait for them
to complete, as well as remove
> put into auto group and "long" group so people can opt out:
> this test almost an hour on my test box.
The group for this is called "stress" - there's no need to introduce
a new group for the same test criteria.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-09-23 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 19:25 [PATCH] xfstests: v2 xfs directory unbalance assert test Mark Tinguely
2013-09-17 19:37 ` Eric Sandeen
2013-09-17 20:03 ` Mark Tinguely
2013-09-17 21:34 ` Dave Chinner
2013-09-17 21:35 ` Eric Sandeen
2013-09-17 22:14 ` Mark Tinguely
2013-09-18 16:36 ` Michael L. Semon
2013-09-18 17:43 ` Mark Tinguely
2013-09-23 23:30 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923233012.GV9901@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox