From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2] xfs: improve xfs_iext_destroy() by freeing extent indirection array directly
Date: Wed, 25 Sep 2013 09:45:37 +1000 [thread overview]
Message-ID: <20130924234537.GE26872@dastard> (raw)
In-Reply-To: <52419C4B.2020603@oracle.com>
On Tue, Sep 24, 2013 at 10:06:03PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> To free the incore file extents stores at an indirection array, we
> call the common routine xfs_iext_irec_remove() to remove a record
> from the array one at a time in reverse order, which will resize an
> extent indirection array repeatedly according to the array size.
>
> This is inefficient for dealing with a file with thousands of incore
> extent records stores at indirection arrays.
>
> This patch improve this kind of things by freeing the extent records
> from the indirection array directly so that we can get benefits for
> reducing the overhead of alloc/free buffers which is depending on the
> number of extents records.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-09-24 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 14:06 [PATCH v2] xfs: improve xfs_iext_destroy() by freeing extent indirection array directly Jeff Liu
2013-09-24 23:45 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924234537.GE26872@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox