Re: [PATCH] xfs: fix memory leak in xlog_recover_add_to_trans

Eric Sandeen
2013-09-27T17:35:38Z

On 9/27/13 12:34 PM, Mark Tinguely wrote:
> On 09/27/13 11:55, Eric Sandeen wrote:
>> On 9/27/13 9:00 AM, tinguely@sgi.com wrote:
>>> Free the memory in error path of xlog_recover_add_to_trans().
>>> Normally this memory is freed in recovery pass2, but is leaked
>>> in the error path.
>>>
>>> Signed-off-by: Mark Tinguely<tinguely@sgi.com>
>>
>> For this local leak & the fix,
>>
>> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>>
>> Since this gets called in a loop from xlog_recover_process_data(),
>> I'm wondering what happens to previously-allocated items, if we
>> return an error and never get to pass2?
>>
>> (I could be off base, haven't really followed it through, but
>> it seems like they might leak).
>>
>> Thanks,
>> -Eric
>
> yeah you are correct, it looks like it gets leaked.
> I will add it to the list.

Thanks. I suppose maybe if it's cleaned up at a higher level,
it doesn't need to be done here, but (*shrug*) I'll let you work
that out. :)

-Eric

> Thanks.
>
> --Mark.