From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 04/16] xfs: decouple log and transaction headers
Date: Fri, 4 Oct 2013 10:49:52 +1000 [thread overview]
Message-ID: <20131004004952.GC4446@dastard> (raw)
In-Reply-To: <20131003145650.GD10316@infradead.org>
On Thu, Oct 03, 2013 at 07:56:50AM -0700, Christoph Hellwig wrote:
> > @@ -33,16 +33,6 @@ struct xfs_log_vec {
> > #define XFS_LOG_VEC_ORDERED (-1)
> >
> > /*
> > - * Structure used to pass callback function and the function's argument
> > - * to the log manager.
> > - */
> > -typedef struct xfs_log_callback {
> > - struct xfs_log_callback *cb_next;
> > - void (*cb_func)(void *, int);
> > - void *cb_arg;
> > -} xfs_log_callback_t;
> > -
> > -/*
>
> Looking at the code I don't think this one needs to be moved as the
> t_logcb field in struct xfs_trans is dead already. Just remove it in
> a separate patch and this declaration can stay where it is.
Ok, I debated whether to just remove the t_logcb fields, and decided
just to move the declaration on the toss of a coin. I'll just remove
it...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-04 0:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 3:06 [PATCH 00/16] xfs: patches for 3.13 Dave Chinner
2013-09-30 3:06 ` [PATCH 01/16] xfs: create a shared header file for format-related information Dave Chinner
2013-10-03 14:50 ` Christoph Hellwig
2013-09-30 3:06 ` [PATCH 02/16] xfs: unify directory/attribute format definitions Dave Chinner
2013-10-03 14:52 ` Christoph Hellwig
2013-10-04 0:47 ` Dave Chinner
2013-09-30 3:07 ` [PATCH 03/16] xfs: split dquot buffer operations out Dave Chinner
2013-10-03 14:52 ` Christoph Hellwig
2013-09-30 3:07 ` [PATCH 04/16] xfs: decouple log and transaction headers Dave Chinner
2013-10-03 14:56 ` Christoph Hellwig
2013-10-04 0:49 ` Dave Chinner [this message]
2013-09-30 3:07 ` [PATCH 05/16] xfs: decouple inode and bmap btree header files Dave Chinner
2013-10-03 14:58 ` Christoph Hellwig
2013-10-04 1:00 ` Dave Chinner
2013-10-15 19:06 ` Christoph Hellwig
2013-09-30 3:07 ` [PATCH 06/16] xfs: split xfs_rtalloc.c for userspace sanity Dave Chinner
2013-10-03 14:59 ` Christoph Hellwig
2013-09-30 3:07 ` [PATCH 07/16] xfs: abstract the differences in dir2/dir3 via an ops vector Dave Chinner
2013-10-03 15:00 ` Christoph Hellwig
2013-09-30 3:07 ` [PATCH 08/16] xfs: vectorise remaining shortform dir2 ops Dave Chinner
2013-10-03 15:00 ` Christoph Hellwig
2013-09-30 3:07 ` [PATCH 09/16] xfs: vectorise directory data operations Dave Chinner
2013-10-03 15:01 ` Christoph Hellwig
2013-09-30 3:07 ` [PATCH 10/16] xfs: vectorise directory data operations part 2 Dave Chinner
2013-10-03 15:01 ` Christoph Hellwig
2013-09-30 3:07 ` [PATCH 11/16] xfs: vectorise directory leaf operations Dave Chinner
2013-10-03 15:01 ` Christoph Hellwig
2013-09-30 3:07 ` [PATCH 12/16] xfs: vectorise DA btree operations Dave Chinner
2013-09-30 3:07 ` [PATCH 13/16] xfs: vectorise encoding/decoding directory headers Dave Chinner
2013-10-02 14:07 ` Michael L. Semon
2013-09-30 3:07 ` [PATCH 14/16] xfs: vectorise directory leaf operations Dave Chinner
2013-09-30 3:07 ` [PATCH 15/16] xfs: convert directory vector functions to constants Dave Chinner
2013-09-30 3:07 ` [PATCH 16/16] xfs: increase inode cluster size for v5 filesystems Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004004952.GC4446@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox