* [PATCH] xfstests: filter projid32bit info out of growfs & info output
@ 2013-10-06 20:09 Eric Sandeen
2013-10-08 0:43 ` Dave Chinner
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2013-10-06 20:09 UTC (permalink / raw)
To: xfs-oss
commit 67e389c xfsprogs: support CRC enabled filesystem detection
changed xfs_growfs (and by extension xfs_info) to report
the projid32bit value. This breaks at least xfstest xfs/206 due to
the changed output, so filter it as we do for mkfs in that test.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/xfs/206 b/tests/xfs/206
index fcbdd9e..d2c2ade 100755
--- a/tests/xfs/206
+++ b/tests/xfs/206
@@ -86,6 +86,7 @@ echo "=== xfs_growfs ==="
xfs_growfs $tmpdir \
| sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" \
-e "s/\(^log.*blocks=\)\([0-9]*,\)/\1XXXXX,/" \
+ -e "s/, projid32bit=[0-9]//" \
-e "/.*crc=/d"
# and double-check the new geometry
@@ -93,6 +94,7 @@ echo "=== xfs_info ==="
xfs_info $tmpdir \
| sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" \
-e "s/\(^log.*blocks=\)\([0-9]*,\)/\1XXXXX,/" \
+ -e "s/, projid32bit=[0-9]//" \
-e "/.*crc=/d"
# _cleanup cleans up for us
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: filter projid32bit info out of growfs & info output
2013-10-06 20:09 [PATCH] xfstests: filter projid32bit info out of growfs & info output Eric Sandeen
@ 2013-10-08 0:43 ` Dave Chinner
2013-10-15 19:16 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2013-10-08 0:43 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Sun, Oct 06, 2013 at 03:09:54PM -0500, Eric Sandeen wrote:
> commit 67e389c xfsprogs: support CRC enabled filesystem detection
>
> changed xfs_growfs (and by extension xfs_info) to report
> the projid32bit value. This breaks at least xfstest xfs/206 due to
> the changed output, so filter it as we do for mkfs in that test.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/tests/xfs/206 b/tests/xfs/206
> index fcbdd9e..d2c2ade 100755
> --- a/tests/xfs/206
> +++ b/tests/xfs/206
> @@ -86,6 +86,7 @@ echo "=== xfs_growfs ==="
> xfs_growfs $tmpdir \
> | sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" \
> -e "s/\(^log.*blocks=\)\([0-9]*,\)/\1XXXXX,/" \
> + -e "s/, projid32bit=[0-9]//" \
> -e "/.*crc=/d"
>
> # and double-check the new geometry
> @@ -93,6 +94,7 @@ echo "=== xfs_info ==="
> xfs_info $tmpdir \
> | sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" \
> -e "s/\(^log.*blocks=\)\([0-9]*,\)/\1XXXXX,/" \
> + -e "s/, projid32bit=[0-9]//" \
> -e "/.*crc=/d"
>
> # _cleanup cleans up for us
Yup, that's needed. There's a bunch of other things we need to do to
correctly test 16/32bit project ids without failures. Have a look
here:
http://oss.sgi.com/archives/xfs/2013-06/msg00219.html
For the mods I posted back in June to avoid failures with the CRC
enabled filesystems in tests that assume certain options can be
turned on/off on XFS filesystems.
I'm still running xfstests with that patch....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-15 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-06 20:09 [PATCH] xfstests: filter projid32bit info out of growfs & info output Eric Sandeen
2013-10-08 0:43 ` Dave Chinner
2013-10-15 19:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox