From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V3] xfstests: restrict 259 device sizes to multiples of 512
Date: Tue, 8 Oct 2013 11:46:41 +1100 [thread overview]
Message-ID: <20131008004641.GT4446@dastard> (raw)
In-Reply-To: <5250CD80.9090708@sandeen.net>
On Sat, Oct 05, 2013 at 09:40:00PM -0500, Eric Sandeen wrote:
> Test 259 tries to make a loop device size which is 1 byte less
> than 4T; losetup now warns that this makes little sense, and
> the warning breaks the test output:
>
> +losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte sector the end of the file will be ignored.
>
> The RH QE testcase did originally use loopback, so did
> not in effect test anything other than 512-multiple boundaries.
>
> Just drop the non-512-byte-multiple cases, they produce
> devices exactly the same size as their 512-byte-multiple
> neighbors.
>
> (FWIW, this is a regression test for the bug that
> d943b11 mkfs: get size of device properly
> fixed.)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-08 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 2:25 [PATCH] xfstests: restrict 259 device sizes to multiples of 512 Eric Sandeen
2013-10-06 2:36 ` [PATCH V2] " Eric Sandeen
2013-10-06 2:40 ` [PATCH V3] " Eric Sandeen
2013-10-08 0:46 ` Dave Chinner [this message]
2013-10-16 20:26 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008004641.GT4446@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox