* [PATCH] xfstests: restrict 259 device sizes to multiples of 512
@ 2013-10-06 2:25 Eric Sandeen
2013-10-06 2:36 ` [PATCH V2] " Eric Sandeen
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2013-10-06 2:25 UTC (permalink / raw)
To: xfs-oss
Test 259 tries to make a loop device size which is 1 byte less
than 4T; losetup now warns that this makes little sense, and
the warning breaks the test output:
+losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte sector the end of the file will be ignored.
The RH QE testcase did originally use loopback, so
did not test anything other than 512 boundaries.
Just drop the 1-byte-shy case, because it produces a device
exactly the same size as the 512-bytes-shy case.
(FWIW, this is a regression test for the bug that
d943b11 mkfs: get size of device properly
fixed.)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/xfs/259 b/tests/xfs/259
index 59eeaca..9c12ccf 100755
--- a/tests/xfs/259
+++ b/tests/xfs/259
@@ -48,7 +48,7 @@ testfile=$TEST_DIR/259.image
# Test various sizes slightly less than 4 TB
four_TB=$(_math "2^42")
-for del in 1 512 1024 1025 2048 4096; do
+for del in 512 1024 1025 2048 4096; do
ddseek=$(_math "$four_TB - $del")
echo "Trying to make (4 TB - $del) B long xfs fs image"
rm -f "$testfile"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V2] xfstests: restrict 259 device sizes to multiples of 512
2013-10-06 2:25 [PATCH] xfstests: restrict 259 device sizes to multiples of 512 Eric Sandeen
@ 2013-10-06 2:36 ` Eric Sandeen
2013-10-06 2:40 ` [PATCH V3] " Eric Sandeen
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2013-10-06 2:36 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
Test 259 tries to make a loop device size which is 1 byte less
than 4T; losetup now warns that this makes little sense, and
the warning breaks the test output:
+losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte sector the end of the file will be ignored.
The RH QE testcase did originally use loopback, so did
not in effect test anything other than 512-multiple boundaries.
Just drop the non-512-byte-multiple cases, they produce
devices exactly the same size as their 512-byte-multiple
neighbors.
(FWIW, this is a regression test for the bug that
d943b11 mkfs: get size of device properly
fixed.)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2, sorry, sent wrong version that still had a 1025 "del"
value.
diff --git a/tests/xfs/259 b/tests/xfs/259
index 59eeaca..9c12ccf 100755
--- a/tests/xfs/259
+++ b/tests/xfs/259
@@ -48,7 +48,7 @@ testfile=$TEST_DIR/259.image
# Test various sizes slightly less than 4 TB
four_TB=$(_math "2^42")
-for del in 1 512 1024 2048 4096; do
+for del in 512 1024 1025 2048 4096; do
ddseek=$(_math "$four_TB - $del")
echo "Trying to make (4 TB - $del) B long xfs fs image"
rm -f "$testfile"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V3] xfstests: restrict 259 device sizes to multiples of 512
2013-10-06 2:36 ` [PATCH V2] " Eric Sandeen
@ 2013-10-06 2:40 ` Eric Sandeen
2013-10-08 0:46 ` Dave Chinner
2013-10-16 20:26 ` Rich Johnston
0 siblings, 2 replies; 5+ messages in thread
From: Eric Sandeen @ 2013-10-06 2:40 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
Test 259 tries to make a loop device size which is 1 byte less
than 4T; losetup now warns that this makes little sense, and
the warning breaks the test output:
+losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte sector the end of the file will be ignored.
The RH QE testcase did originally use loopback, so did
not in effect test anything other than 512-multiple boundaries.
Just drop the non-512-byte-multiple cases, they produce
devices exactly the same size as their 512-byte-multiple
neighbors.
(FWIW, this is a regression test for the bug that
d943b11 mkfs: get size of device properly
fixed.)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2, sorry, sent wrong version that still had a 1025 "del"
value.
V3, .out file too, cripes. No more saturday night patches,
sorry.
diff --git a/tests/xfs/259 b/tests/xfs/259
index 59eeaca..b8bd69a 100755
--- a/tests/xfs/259
+++ b/tests/xfs/259
@@ -48,7 +48,7 @@ testfile=$TEST_DIR/259.image
# Test various sizes slightly less than 4 TB
four_TB=$(_math "2^42")
-for del in 1 512 1024 1025 2048 4096; do
+for del in 512 1024 2048 4096; do
ddseek=$(_math "$four_TB - $del")
echo "Trying to make (4 TB - $del) B long xfs fs image"
rm -f "$testfile"
diff --git a/tests/xfs/259.out b/tests/xfs/259.out
index 263bb1b..6e0be9a 100644
--- a/tests/xfs/259.out
+++ b/tests/xfs/259.out
@@ -1,7 +1,5 @@
QA output created by 259
-Trying to make (4 TB - 1) B long xfs fs image
Trying to make (4 TB - 512) B long xfs fs image
Trying to make (4 TB - 1024) B long xfs fs image
-Trying to make (4 TB - 1025) B long xfs fs image
Trying to make (4 TB - 2048) B long xfs fs image
Trying to make (4 TB - 4096) B long xfs fs image
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V3] xfstests: restrict 259 device sizes to multiples of 512
2013-10-06 2:40 ` [PATCH V3] " Eric Sandeen
@ 2013-10-08 0:46 ` Dave Chinner
2013-10-16 20:26 ` Rich Johnston
1 sibling, 0 replies; 5+ messages in thread
From: Dave Chinner @ 2013-10-08 0:46 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Eric Sandeen, xfs-oss
On Sat, Oct 05, 2013 at 09:40:00PM -0500, Eric Sandeen wrote:
> Test 259 tries to make a loop device size which is 1 byte less
> than 4T; losetup now warns that this makes little sense, and
> the warning breaks the test output:
>
> +losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte sector the end of the file will be ignored.
>
> The RH QE testcase did originally use loopback, so did
> not in effect test anything other than 512-multiple boundaries.
>
> Just drop the non-512-byte-multiple cases, they produce
> devices exactly the same size as their 512-byte-multiple
> neighbors.
>
> (FWIW, this is a regression test for the bug that
> d943b11 mkfs: get size of device properly
> fixed.)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V3] xfstests: restrict 259 device sizes to multiples of 512
2013-10-06 2:40 ` [PATCH V3] " Eric Sandeen
2013-10-08 0:46 ` Dave Chinner
@ 2013-10-16 20:26 ` Rich Johnston
1 sibling, 0 replies; 5+ messages in thread
From: Rich Johnston @ 2013-10-16 20:26 UTC (permalink / raw)
To: Eric Sandeen, Eric Sandeen; +Cc: xfs-oss
This has been committed.
Thanks
--Rich
commit aaac93cb801e733af92c531c4f0aebac337ee7b8
Author: Eric Sandeen <sandeen@sandeen.net>
Date: Sun Oct 6 02:40:00 2013 +0000
xfstests: restrict 259 device sizes to multiples of 512
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-16 20:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-06 2:25 [PATCH] xfstests: restrict 259 device sizes to multiples of 512 Eric Sandeen
2013-10-06 2:36 ` [PATCH V2] " Eric Sandeen
2013-10-06 2:40 ` [PATCH V3] " Eric Sandeen
2013-10-08 0:46 ` Dave Chinner
2013-10-16 20:26 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox