Re: [PATCH V3] xfstests: restrict 259 device sizes to multiples of 512

Dave Chinner
2013-10-08T00:46:46Z

On Sat, Oct 05, 2013 at 09:40:00PM -0500, Eric Sandeen wrote:
> Test 259 tries to make a loop device size which is 1 byte less
> than 4T; losetup now warns that this makes little sense, and
> the warning breaks the test output:
>
> +losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte sector the end of the file will be ignored.
>
> The RH QE testcase did originally use loopback, so did
> not in effect test anything other than 512-multiple boundaries.
>
> Just drop the non-512-byte-multiple cases, they produce
> devices exactly the same size as their 512-byte-multiple
> neighbors.
>
> (FWIW, this is a regression test for the bug that
> d943b11 mkfs: get size of device properly
> fixed.)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com