Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore

Eric Sandeen
2013-10-08T00:58:51Z

On 10/7/13 7:57 PM, Eric Sandeen wrote:
> On 10/7/13 7:53 PM, Dave Chinner wrote:
>> Two tests, please. move all the common parts into common/dump, and
>> write them as two separate tests. That way we can easily track what
>> test is failing just by looking at what harness test is failing...
>
> I'm not quite convinced that it's 2 separate tests, TBH.
>
> It's the same root cause; I guess there is a slightly different
> outcome because if you hit the same root cause enough times,
> you'll segfault. That's the only difference in test #2.
> (and the segfault isn't fixed AFAIK).

Or to be clearer - I'm not sure that test1 is testing anything
fundamentally different from test2.

-Eric