From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 1EF9F7F37 for ; Mon, 14 Oct 2013 15:03:54 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id F140F8F804C for ; Mon, 14 Oct 2013 13:03:50 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id gM6UCRv72WqDz7ar for ; Mon, 14 Oct 2013 13:03:49 -0700 (PDT) Date: Tue, 15 Oct 2013 07:03:45 +1100 From: Dave Chinner Subject: Re: [PATCH 4/5] xfs: simplify the fallocate path Message-ID: <20131014200345.GK4446@dastard> References: <20131012075503.370510641@bombadil.infradead.org> <20131012075640.467511096@bombadil.infradead.org> <20131014050424.GI4446@dastard> <20131014073047.GB21013@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131014073047.GB21013@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Mon, Oct 14, 2013 at 12:30:47AM -0700, Christoph Hellwig wrote: > On Mon, Oct 14, 2013 at 04:04:24PM +1100, Dave Chinner wrote: > > Seems a bit clunky to do all this work when we've got to repeat most > > of it when when we call xfs_setattr_size() if the size has changed. > > Any thoughts on how we might reduce to a single transaction? > > I tried that, but the helper becomes a complete mess of flag values for the > possible inode modifications. You also pointed this out the last time > around. If anyone can come up with a saner helper than I tired feel > free to send a patch on top. OK, no worries. Consider it: Reviewed-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs