From: Dave Chinner <david@fromorbit.com>
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, xfs@oss.sgi.com
Subject: Re: [PATCH RESEND V2] xfstests: Incorrect check for gdbm/ndbm.h
Date: Tue, 15 Oct 2013 07:09:35 +1100 [thread overview]
Message-ID: <20131014200935.GM4446@dastard> (raw)
In-Reply-To: <1381762899-6799-1-git-send-email-stanislav.kholmanskikh@oracle.com>
On Mon, Oct 14, 2013 at 07:01:39PM +0400, Stanislav Kholmanskikh wrote:
> Current version of AC_PACKAGE_WANT_NDBM has following bugs:
> * a typo (',') next to 'gdbm/ndbm.h', so C compiler fails
> with a syntax error when trying to compile
> "#include <gdbm/ndbm.h,>"
>
> * autoconf never defines HAVE_GDBM_NDBM_H_ because it
> converts both header names (gdbm/ndbm.h, gdbm-ndbm.h)
> to GDBM_NDBM_H
>
> Because of these bugs 'dbtest' can't be compiled on systems where
> 'gdbm-ndbm.h' header is absent but 'gdbm/ndbm.h' is present.
>
> Fixed this.
>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Looks good now.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-14 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 10:01 [PATCH] Incorrect check for gdbm/ndbm.h Stanislav Kholmanskikh
2013-10-11 6:42 ` [PATCH RESEND] xfstests: " Stanislav Kholmanskikh
2013-10-13 21:57 ` Dave Chinner
2013-10-14 15:01 ` [PATCH RESEND V2] " Stanislav Kholmanskikh
2013-10-14 20:09 ` Dave Chinner [this message]
2013-10-16 20:39 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014200935.GM4446@dastard \
--to=david@fromorbit.com \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox