From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: prevent deadlock trying to cover an active log
Date: Mon, 14 Oct 2013 15:36:23 -0500 [thread overview]
Message-ID: <20131014203623.GW10553@sgi.com> (raw)
In-Reply-To: <20131014202234.GO4446@dastard>
On Tue, Oct 15, 2013 at 07:22:34AM +1100, Dave Chinner wrote:
> On Mon, Oct 14, 2013 at 03:04:22PM -0500, Ben Myers wrote:
> > Hey Fellas,
> > > > diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> > > > index 136654b..de24ffb 100644
> > > > --- a/fs/xfs/xfs_log_priv.h
> > > > +++ b/fs/xfs/xfs_log_priv.h
> > > > @@ -514,12 +514,10 @@ xlog_assign_grant_head(atomic64_t *head, int cycle, int space)
> > > > /*
> > > > * Committed Item List interfaces
> > > > */
> > > > -int
> > > > -xlog_cil_init(struct xlog *log);
> > > > -void
> > > > -xlog_cil_init_post_recovery(struct xlog *log);
> > > > -void
> > > > -xlog_cil_destroy(struct xlog *log);
> > > > +int xlog_cil_init(struct xlog *log);
> > > > +void xlog_cil_init_post_recovery(struct xlog *log);
> > > > +void xlog_cil_destroy(struct xlog *log);
> > > > +bool xlog_cil_empty(struct xlog *log)
> >
> > Huh. Looks like we're short a semicolon here. I can add one, unless you
> > prefer to repost?
>
> \o/
>
> Someone finally noticed I sent a broken patch.
>
> I forgot to refresh the commit before I sent it, so this was fixed
> before I even posted it. :/
>
> Current version of the patch is below.
We'll take this one then. ;)
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-10-14 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 0:31 [PATCH] xfs: prevent deadlock trying to cover an active log Dave Chinner
2013-10-10 17:05 ` Eric Sandeen
2013-10-10 21:42 ` Dave Chinner
2013-10-11 3:23 ` Eric Sandeen
2013-10-11 3:40 ` Eric Sandeen
2013-10-14 20:04 ` Ben Myers
2013-10-14 20:22 ` Dave Chinner
2013-10-14 20:36 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014203623.GW10553@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox