From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag
Date: Thu, 17 Oct 2013 16:17:40 -0500 [thread overview]
Message-ID: <20131017211740.GK1935@sgi.com> (raw)
In-Reply-To: <20131017200315.GA26616@infradead.org>
Hey Christoph,
On Thu, Oct 17, 2013 at 01:03:15PM -0700, Christoph Hellwig wrote:
> On Thu, Oct 17, 2013 at 03:01:09PM -0500, Ben Myers wrote:
> > An xfs ioctl user who requests nonblocking behavior will no longer get it.
> > This seems to constitute API breakage. How can we verify that this is unused
> > since anyone can open with O_NONBLOCK?
>
> The flag isn't checked anywhere, which means it doesn't have any effect,
> and doesn't as far as I can look back.
Gah. I was about to say that you just removed the last usage of it in patch 1!
But that patch is about NOLOCK, not NONBLOCK. I should get my eyes checked. ;)
Anyway, XFS_ATTR_NONBLOCK is used by dmapi so that nfs threads don't block for
offline files. Folks who care about that sort of thing will have to add it
back in. That's fine.
FWIW, you can see that here:
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs.git;a=shortlog;h=refs/heads/v3.0-xfs_dmapi
> I also don't know how the
> prealloc ioctls could behave non-blocking in any sane way.
Right. Nfsd doesn't use any of those ioctls, so I don't really see the point
either.
Looks like my concern was unfounded.
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-17 21:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 7:55 [PATCH 0/5] refactor the preallocation and hole punching code Christoph Hellwig
2013-10-12 7:55 ` [PATCH 1/5] xfs: always take the iolock around xfs_setattr_size Christoph Hellwig
2013-10-14 4:50 ` Dave Chinner
2013-10-14 7:29 ` Christoph Hellwig
2013-10-14 14:09 ` [PATCH 1/5 v3] " Christoph Hellwig
2013-10-14 20:28 ` Dave Chinner
2013-10-12 7:55 ` [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag Christoph Hellwig
2013-10-14 4:51 ` Dave Chinner
2013-10-17 20:01 ` Ben Myers
2013-10-17 20:03 ` Christoph Hellwig
2013-10-17 21:17 ` Ben Myers [this message]
2013-10-12 7:55 ` [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space Christoph Hellwig
2013-10-14 4:55 ` Dave Chinner
2013-10-12 7:55 ` [PATCH 4/5] xfs: simplify the fallocate path Christoph Hellwig
2013-10-14 5:04 ` Dave Chinner
2013-10-14 7:30 ` Christoph Hellwig
2013-10-14 20:03 ` Dave Chinner
2013-10-12 7:55 ` [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space Christoph Hellwig
2013-10-14 5:08 ` Dave Chinner
2013-10-15 15:31 ` Christoph Hellwig
2013-10-15 21:47 ` Dave Chinner
2013-10-16 7:03 ` Christoph Hellwig
2013-10-21 21:58 ` [PATCH 0/5] refactor the preallocation and hole punching code Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017211740.GK1935@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox