Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag

Ben Myers
2013-10-17T20:01:13Z

Gents,

On Mon, Oct 14, 2013 at 03:51:52PM +1100, Dave Chinner wrote:
> On Sat, Oct 12, 2013 at 12:55:05AM -0700, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Still unused after all this time, so removing it is fine by me.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

An xfs ioctl user who requests nonblocking behavior will no longer get it.
This seems to constitute API breakage. How can we verify that this is unused
since anyone can open with O_NONBLOCK?

Regards,
Ben