Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag

Christoph Hellwig
2013-10-17T20:03:19Z

On Thu, Oct 17, 2013 at 03:01:09PM -0500, Ben Myers wrote:
> An xfs ioctl user who requests nonblocking behavior will no longer get it.
> This seems to constitute API breakage. How can we verify that this is unused
> since anyone can open with O_NONBLOCK?

The flag isn't checked anywhere, which means it doesn't have any effect,
and doesn't as far as I can look back. I also don't know how the
prealloc ioctls could behave non-blocking in any sane way.