Re: [PATCH 0/5] refactor the preallocation and hole punching code

Ben Myers
2013-10-21T21:58:41Z

Hi Christoph,

On Sat, Oct 12, 2013 at 12:55:03AM -0700, Christoph Hellwig wrote:
> This series massages the preallocation and hole punching code into something
> sane. The big catchall xfs_change_file_space function is gone, fallocate
> and the ioctl entry point now directly call the low-level functions, and
> fallocate can avoid packing its arguments into the xfs_flock form and
> duplicating error checking already done in the VFS. In addition we also
> use a common locking patter now, that is preallocations using the ioctl
> path now also take iolock, just like fallocate and all other ioctl cases
> already did beforehand.
>
>
> Changes since version 1:
> - remove the unused setprealloc variable in xfs_file_fallocate
> - rebased

Applied this series.

Thanks,
Ben