Re: [PATCH 1/5] xfs: always take the iolock around xfs_setattr_size

Christoph Hellwig
2013-10-14T07:29:50Z

On Mon, Oct 14, 2013 at 03:50:07PM +1100, Dave Chinner wrote:
> I think there should be a bit more cleanup of this lock_flags
> variable. There's quite a few error paths that now "goto out_unlock"
> without actually holding a lock. i.e. they could just become a
> straight "return error", and lock_flags can probably go away
> completely...

I'll look into that.