Re: [PATCH 4/5] xfs: simplify the fallocate path

Dave Chinner
2013-10-14T20:03:54Z

On Mon, Oct 14, 2013 at 12:30:47AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 14, 2013 at 04:04:24PM +1100, Dave Chinner wrote:
> > Seems a bit clunky to do all this work when we've got to repeat most
> > of it when when we call xfs_setattr_size() if the size has changed.
> > Any thoughts on how we might reduce to a single transaction?
>
> I tried that, but the helper becomes a complete mess of flag values for the
> possible inode modifications. You also pointed this out the last time
> around. If anyone can come up with a saner helper than I tired feel
> free to send a patch on top.

OK, no worries. Consider it:

Reviewed-by: Dave Chinner <dchinner@redhat.com>

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com