public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/6] xfstests: add a multithreaded mode to bstat
Date: Fri, 18 Oct 2013 14:00:40 +1100	[thread overview]
Message-ID: <20131018030039.GS4446@dastard> (raw)
In-Reply-To: <526056AC.4000307@sandeen.net>

On Thu, Oct 17, 2013 at 04:29:16PM -0500, Eric Sandeen wrote:
> On 6/7/13 8:06 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> > 
> > For benchmarking of bulkstat, add a multithreaded mode that spawns a
> > thread per AG and runs bulkstat on every AG in parallel. There is a
> > small amount of overlap between each AG because of the way the
> > interface works only on inode numbers, so some inodes are reported
> > twice. A real implementation of this sort of parallelism would be
> > greatly helped by adding an AG parameter to the bulkstat interface.
> > 
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> 
> At least w/ older xfsprogs[[qa]-devel] packages, I get:
> 
> bstat.c:41: error: redefinition of 'fls'
> /usr/include/xfs/bitops.h:8: note: previous definition of 'fls' was here
> bstat.c:70: error: redefinition of 'xfs_highbit32'
> /usr/include/xfs/xfs_bit.h:50: note: previous definition of 'xfs_highbit32' was here
> 
> w/ the new functions you've added here...

Ok, so I need autoconf magic here to detect this?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-10-18  3:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 13:06 [PATCH 0/6] xfstests: various fixes Dave Chinner
2013-06-07 13:06 ` [PATCH 1/6] xfstests: generic/193 runs tests in wrong location Dave Chinner
2013-06-25 19:49   ` Ben Myers
2013-06-07 13:06 ` [PATCH 2/6] xfstests: ensure all mkfs output is redirected properly Dave Chinner
2013-06-07 13:06 ` [PATCH 3/6] xfstests: xfs/253 doesn't use seqres correctly Dave Chinner
2013-06-25 20:27   ` Ben Myers
2013-06-07 13:06 ` [PATCH 4/6] xfstests: Make 204 work with different block and inode sizes Dave Chinner
2013-06-07 13:06 ` [PATCH 5/6] xfstests: New _require_* tests for CRC enabled filesystems Dave Chinner
2013-10-17 21:24   ` Eric Sandeen
2013-10-18  2:58     ` Dave Chinner
2013-06-07 13:06 ` [PATCH 6/6] xfstests: add a multithreaded mode to bstat Dave Chinner
2013-10-17 21:29   ` Eric Sandeen
2013-10-18  3:00     ` Dave Chinner [this message]
2013-10-18  3:39       ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131018030039.GS4446@dastard \
    --to=david@fromorbit.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox