From: Dave Chinner <david@fromorbit.com>
To: Rich Johnston <rjohnston@sgi.com>
Cc: vasily.isaenko@oracle.com, xfs@oss.sgi.com,
Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Subject: Re: [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo
Date: Thu, 24 Oct 2013 12:09:29 +1100 [thread overview]
Message-ID: <20131024010929.GR2797@dastard> (raw)
In-Reply-To: <52686670.6080607@sgi.com>
On Wed, Oct 23, 2013 at 07:14:40PM -0500, Rich Johnston wrote:
> This has been committed.
Without commiting the other patch that implements
_no_of_online_cpus....
> Thanks
> --Rich
>
> commit fd080d64b6e9677cb9d0a15dc7e308b6ca0e273f
> Author: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> Date: Wed Oct 23 11:58:44 2013 +0000
>
> xfstests: generic/273: do not use /proc/cpuinfo
generic/273 22s ... - output mismatch (see /home/dave/src/xfstests-dev/results//generic/273.out.bad)
--- tests/generic/273.out 2013-03-28 07:53:08.000000000 +1100
+++ /home/dave/src/xfstests-dev/results//generic/273.out.bad 2013-10-24 12:06:27.000000000 +1100
@@ -2,3 +2,5 @@
------------------------------
start the workload
------------------------------
+./tests/generic/273: line 50: _no_of_online_cpus: command not found
+./tests/generic/273: line 51: * 50: syntax error: operand expected (error token is "* 50")
...
(Run 'diff -u tests/generic/273.out /home/dave/src/xfstests-dev/results//generic/273.out.bad' to see the entire diff)
Ran: generic/273
Failures: generic/273
Failed 1 of 1 tests
Rich, can you try to commit patch series as a whole, not piecemeal
while parts of the patch series are still being discussed and
reviewed?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-24 1:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 11:58 Avoid of using /proc/cpuinfo in generic tests Stanislav Kholmanskikh
2013-10-23 11:58 ` [PATCH 1/2] xfstests: implemented _no_of_online_cpus() function Stanislav Kholmanskikh
2013-10-23 13:08 ` Carlos Maiolino
2013-10-23 21:31 ` Dave Chinner
2013-10-24 8:56 ` [PATCH] xfstests: src/feature.c: print a number of online CPUs Stanislav Kholmanskikh
2013-10-24 10:40 ` Dave Chinner
2013-10-24 12:10 ` [PATCH V2] " Stanislav Kholmanskikh
2013-10-28 22:15 ` Dave Chinner
2013-10-29 10:03 ` [PATCH V3] " Stanislav Kholmanskikh
2013-11-05 12:41 ` Stanislav Kholmanskikh
2013-11-10 1:19 ` Rich Johnston
2013-11-10 1:20 ` Rich Johnston
2013-10-24 13:18 ` [PATCH] " Carlos Maiolino
2013-10-24 14:33 ` Stanislav Kholmanskikh
2013-10-24 21:23 ` Dave Chinner
2013-10-28 7:23 ` Stanislav Kholmanskikh
2013-10-28 12:23 ` Carlos Maiolino
2013-10-23 11:58 ` [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo Stanislav Kholmanskikh
2013-10-23 13:09 ` Carlos Maiolino
2013-10-24 0:14 ` Rich Johnston
2013-10-24 1:09 ` Dave Chinner [this message]
2013-11-11 9:34 ` [PATCH] xfstests: generic/273: use src/feature -o Stanislav Kholmanskikh
2013-11-11 11:10 ` Jeff Liu
2013-11-11 16:05 ` Rich Johnston
2013-11-11 16:06 ` Rich Johnston
2013-11-11 14:50 ` [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024010929.GR2797@dastard \
--to=david@fromorbit.com \
--cc=rjohnston@sgi.com \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox