From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: XFS Community <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstest: fix filtering in 206 for ftype and projid32bit
Date: Sun, 27 Oct 2013 20:11:21 +1100 [thread overview]
Message-ID: <20131027091121.GB2797@dastard> (raw)
In-Reply-To: <5269A35F.5080500@sgi.com>
On Thu, Oct 24, 2013 at 05:46:55PM -0500, Mark Tinguely wrote:
> On 10/24/13 17:11, Dave Chinner wrote:
> >On Thu, Oct 24, 2013 at 04:56:42PM -0500, Mark Tinguely wrote:
> >>xfs/206 displays the output for mkfs.xfs, xfs_growfs and xfs_info.
> >>Change the filtering to hide the new output for the field type
> >>feature.
> >>
> >>While cleaning up the ftype output, also clean up the projid32bit
> >>output in xfs_growfs and xfs_info.
> >
> >What about the _filter_mkfs function that other tests use?
> >
> >Cheers,
> >
> >Dave.
>
> From what I can tell, it does not need changing.
We really should be exporting the values as shell variables to
stderr for any test that wants to use them. We don't need to output
them to stdout at this point (as that will break all the golden
images), but all the mkfs config values should be accessible from
the filter.
i.e. _filter_mkfs is infrastructure and when new things are added,
the infrastructure needs to be updated as well. IOWs, this should
work after you've added support for ftype to xfstests:
_scratch_mkfs | _mkfs_filter 2> $tmp.mkfs > /dev/null
. $tmp.mkfs
if [ $nftype -eq 1 ]; then
.....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-27 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:56 [PATCH] xfstest: fix filtering in 206 for ftype and projid32bit Mark Tinguely
2013-10-24 22:11 ` Dave Chinner
2013-10-24 22:46 ` Mark Tinguely
2013-10-27 9:11 ` Dave Chinner [this message]
2013-11-10 1:09 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027091121.GB2797@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox