From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix compile error of src/fssum.c on bigendian host
Date: Wed, 30 Oct 2013 15:21:34 +1100 [thread overview]
Message-ID: <20131030042134.GF6188@dastard> (raw)
In-Reply-To: <1383105343-15348-1-git-send-email-eguan@redhat.com>
On Wed, Oct 30, 2013 at 11:55:43AM +0800, Eryu Guan wrote:
> Definition of htonll() is needed on bigendian host too, otherwise
> src/fssum.c won't compile on ppc64/s390x hosts.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> src/fssum.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/fssum.c b/src/fssum.c
> index c75ff8b..c26d32b 100644
> --- a/src/fssum.c
> +++ b/src/fssum.c
> @@ -50,6 +50,8 @@
>
> #if __BYTE_ORDER == __LITTLE_ENDIAN
> #define htonll(x) __bswap_64 (x)
> +#else
> +#define htonll(x) (x)
> #endif
> #endif
Looks fine.
Acked-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-30 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 3:55 [PATCH] xfstests: fix compile error of src/fssum.c on bigendian host Eryu Guan
2013-10-30 4:21 ` Dave Chinner [this message]
2013-10-31 12:12 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030042134.GF6188@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox