* Re: xfstests 317 [not found] ` <20131024162557.6dd72435@oracle.com> @ 2013-10-25 9:33 ` Christoph Hellwig 2013-10-28 15:43 ` Dwight Engen 0 siblings, 1 reply; 7+ messages in thread From: Christoph Hellwig @ 2013-10-25 9:33 UTC (permalink / raw) To: Dwight Engen; +Cc: xfs On Thu, Oct 24, 2013 at 04:25:57PM -0400, Dwight Engen wrote: > On Thu, 24 Oct 2013 09:12:35 -0700 > Christoph Hellwig <hch@infradead.org> wrote: > > > This one also seems to be guranteed to fail for me with the following > > output: > > > > > > --- tests/generic/317.out 2013-09-09 14:41:08.000000000 +0000 > > +++ /root/xfstests/results//generic/317.out.bad 2013-10-24 > > 16:12:00.000000000 +0000 @@ -4,9 +4,7 @@ > > Size: 0 Filetype: Regular File > > Mode: (0644/-rw-r--r--) Uid: (qa_user) Gid: (qa_user) > > From user_ns > > - File: "$SCRATCH_MNT/file1" > > - Size: 0 Filetype: Regular File > > - Mode: (0644/-rw-r--r--) Uid: (0) Gid: (0) > > +execvp: Permission denied > > Hi Christoph, > > Hmm, this looks to me like src/lstat64 cannot be exec()ed by qa_user on > your system. Is there some other id I can/should use? That doesn't seem to be the issue from the main system for me: root@vm:~/xfstests# sudo -u fsgqa ./src/lstat64 Usage: lstat64 [-t] filename ... Do you have a one liner to try what happens in a namespace? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xfstests 317 2013-10-25 9:33 ` xfstests 317 Christoph Hellwig @ 2013-10-28 15:43 ` Dwight Engen 2013-10-30 16:19 ` Christoph Hellwig 0 siblings, 1 reply; 7+ messages in thread From: Dwight Engen @ 2013-10-28 15:43 UTC (permalink / raw) To: Christoph Hellwig; +Cc: xfs On Fri, 25 Oct 2013 02:33:33 -0700 Christoph Hellwig <hch@infradead.org> wrote: > On Thu, Oct 24, 2013 at 04:25:57PM -0400, Dwight Engen wrote: > > On Thu, 24 Oct 2013 09:12:35 -0700 > > Christoph Hellwig <hch@infradead.org> wrote: > > > > > This one also seems to be guranteed to fail for me with the > > > following output: > > > > > > > > > --- tests/generic/317.out 2013-09-09 14:41:08.000000000 > > > +0000 +++ /root/xfstests/results//generic/317.out.bad > > > 2013-10-24 16:12:00.000000000 +0000 @@ -4,9 +4,7 @@ > > > Size: 0 Filetype: Regular File > > > Mode: (0644/-rw-r--r--) Uid: (qa_user) Gid: (qa_user) > > > From user_ns > > > - File: "$SCRATCH_MNT/file1" > > > - Size: 0 Filetype: Regular File > > > - Mode: (0644/-rw-r--r--) Uid: (0) Gid: (0) > > > +execvp: Permission denied > > > > Hi Christoph, > > > > Hmm, this looks to me like src/lstat64 cannot be exec()ed by > > qa_user on your system. Is there some other id I can/should use? > > That doesn't seem to be the issue from the main system for me: > > root@vm:~/xfstests# sudo -u fsgqa ./src/lstat64 > Usage: lstat64 [-t] filename ... > > Do you have a one liner to try what happens in a namespace? Hi Cristoph, on my system (where fsgqa is id 501) the one liner the test is running is: # ./src/nsexec -s -U -M "0 501 1000" -G "0 501 1000" ./src/lstat64 Usage: lstat64 [-t] filename ... Since you are getting to the point where it is trying to print out the ids, that means you already ran nsexec once for the touch command to create the file, which is why I think it is something to do with exec()ing lstat64. You could try replacing the 501 in the -G with the group id of fsgqa since it is possibly not 501 also, but I don't see how that is the problem. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xfstests 317 2013-10-28 15:43 ` Dwight Engen @ 2013-10-30 16:19 ` Christoph Hellwig 2013-10-30 16:24 ` Christoph Hellwig 0 siblings, 1 reply; 7+ messages in thread From: Christoph Hellwig @ 2013-10-30 16:19 UTC (permalink / raw) To: Dwight Engen; +Cc: Christoph Hellwig, xfs On Mon, Oct 28, 2013 at 11:43:28AM -0400, Dwight Engen wrote: > Hi Cristoph, on my system (where fsgqa is id 501) the one liner the > test is running is: > > # ./src/nsexec -s -U -M "0 501 1000" -G "0 501 1000" ./src/lstat64 > Usage: lstat64 [-t] filename ... The id here is 1000 and the following works just fine: /src/nsexec -s -U -M "0 1000 1000" -G "0 1000 1000" ./src/lstat64 Usage: lstat64 [-t] filename ... _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xfstests 317 2013-10-30 16:19 ` Christoph Hellwig @ 2013-10-30 16:24 ` Christoph Hellwig 2013-10-30 18:30 ` [PATCH] xfstests: generic/317 use relative paths to avoid traversal permission problems Dwight Engen 0 siblings, 1 reply; 7+ messages in thread From: Christoph Hellwig @ 2013-10-30 16:24 UTC (permalink / raw) To: Dwight Engen; +Cc: xfs On Wed, Oct 30, 2013 at 09:19:55AM -0700, Christoph Hellwig wrote: > On Mon, Oct 28, 2013 at 11:43:28AM -0400, Dwight Engen wrote: > > Hi Cristoph, on my system (where fsgqa is id 501) the one liner the > > test is running is: > > > > # ./src/nsexec -s -U -M "0 501 1000" -G "0 501 1000" ./src/lstat64 > > Usage: lstat64 [-t] filename ... > > The id here is 1000 and the following works just fine: > > /src/nsexec -s -U -M "0 1000 1000" -G "0 1000 1000" ./src/lstat64 > Usage: lstat64 [-t] filename ... But: ./src/nsexec -s -U -M "0 1000 1000" -G "0 501 1000" /root/xfstests/src/lstat64 execvp: Permission denied Which is probably due to: root@vm:~/xfstests# ls -ld ~ drwx------ 6 root root 4096 Oct 30 16:24 /root Guess we need a relative path here? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] xfstests: generic/317 use relative paths to avoid traversal permission problems 2013-10-30 16:24 ` Christoph Hellwig @ 2013-10-30 18:30 ` Dwight Engen 2013-10-31 15:40 ` Christoph Hellwig 2013-11-04 20:43 ` Rich Johnston 0 siblings, 2 replies; 7+ messages in thread From: Dwight Engen @ 2013-10-30 18:30 UTC (permalink / raw) To: Christoph Hellwig; +Cc: xfs On Wed, 30 Oct 2013 09:24:41 -0700 Christoph Hellwig <hch@infradead.org> wrote: > On Wed, Oct 30, 2013 at 09:19:55AM -0700, Christoph Hellwig wrote: > > On Mon, Oct 28, 2013 at 11:43:28AM -0400, Dwight Engen wrote: > > > Hi Cristoph, on my system (where fsgqa is id 501) the one liner > > > the test is running is: > > > > > > # ./src/nsexec -s -U -M "0 501 1000" -G "0 501 1000" ./src/lstat64 > > > Usage: lstat64 [-t] filename ... > > > > The id here is 1000 and the following works just fine: > > > > /src/nsexec -s -U -M "0 1000 1000" -G "0 1000 1000" ./src/lstat64 > > Usage: lstat64 [-t] filename ... > > But: > > ./src/nsexec -s -U -M "0 1000 1000" -G "0 501 > 1000" /root/xfstests/src/lstat64 execvp: Permission denied > > > Which is probably due to: > root@vm:~/xfstests# ls -ld ~ > drwx------ 6 root root 4096 Oct 30 16:24 /root > > > Guess we need a relative path here? Yep, that makes sense. I modeled this on 219 which was using $here/src/lstat64 but didn't think about the fact that in my test fsgqa might have traversal problems. I see plenty of other tests are using relative paths so the following patch should (hopefully) fix 317 for you. Thanks for tracking it down. -- Signed-off-by: Dwight Engen <dwight.engen@oracle.com> --- tests/generic/317 | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) mode change 100644 => 100755 tests/generic/317 diff --git a/tests/generic/317 b/tests/generic/317 old mode 100644 new mode 100755 index 6d8d3c4..f5d1b21 --- a/tests/generic/317 +++ b/tests/generic/317 @@ -46,8 +46,6 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 . ./common/filter . ./common/attr -nsexec=$here/src/nsexec -lstat64=$here/src/lstat64 file=$SCRATCH_MNT/file1 # real QA test starts here @@ -75,10 +73,10 @@ _filter_output() _print_numeric_uid() { echo "From init_user_ns" - $here/src/lstat64 $file |head -3 |_filter_output + src/lstat64 $file |head -3 |_filter_output echo "From user_ns" - $nsexec -s -U -M "0 $qa_user_id 1000" -G "0 $qa_user_id 1000" $here/src/lstat64 $file |head -3 |_filter_output + src/nsexec -s -U -M "0 $qa_user_id 1000" -G "0 $qa_user_id 1000" src/lstat64 $file |head -3 |_filter_output } umount $SCRATCH_DEV >/dev/null 2>&1 @@ -89,7 +87,7 @@ _scratch_mount >>$seqres.full 2>&1 || _fail "mount failed" chmod 777 $SCRATCH_MNT # create $file as "root" in userns, which is $qa_user in parent namespace -$nsexec -s -U -M "0 $qa_user_id 1000" -G "0 $qa_user_id 1000" touch $file +src/nsexec -s -U -M "0 $qa_user_id 1000" -G "0 $qa_user_id 1000" touch $file _print_numeric_uid -- 1.7.1 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] xfstests: generic/317 use relative paths to avoid traversal permission problems 2013-10-30 18:30 ` [PATCH] xfstests: generic/317 use relative paths to avoid traversal permission problems Dwight Engen @ 2013-10-31 15:40 ` Christoph Hellwig 2013-11-04 20:43 ` Rich Johnston 1 sibling, 0 replies; 7+ messages in thread From: Christoph Hellwig @ 2013-10-31 15:40 UTC (permalink / raw) To: Dwight Engen; +Cc: xfs On Wed, Oct 30, 2013 at 02:30:50PM -0400, Dwight Engen wrote: > Yep, that makes sense. I modeled this on 219 which was using > $here/src/lstat64 but didn't think about the fact that in my test fsgqa > might have traversal problems. I see plenty of other tests are using > relative paths so the following patch should (hopefully) fix 317 for you. > Thanks for tracking it down. Thanks, this fixes the problem for me. Reviewed-by: Christoph Hellwig <hch@lst.de> _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xfstests: generic/317 use relative paths to avoid traversal permission problems 2013-10-30 18:30 ` [PATCH] xfstests: generic/317 use relative paths to avoid traversal permission problems Dwight Engen 2013-10-31 15:40 ` Christoph Hellwig @ 2013-11-04 20:43 ` Rich Johnston 1 sibling, 0 replies; 7+ messages in thread From: Rich Johnston @ 2013-11-04 20:43 UTC (permalink / raw) To: Dwight Engen, Christoph Hellwig; +Cc: xfs This has been committed. Thanks --Rich commit 4818302fbf5c4c64dbe2fb3e504e71ceafff50e3 Author: Dwight Engen <dwight.engen@oracle.com> Date: Wed Oct 30 18:30:50 2013 +0000 xfstests: generic/317 use relative paths to avoid traversal permission problems _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-11-04 20:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20131024161235.GA29381@infradead.org>
[not found] ` <20131024162557.6dd72435@oracle.com>
2013-10-25 9:33 ` xfstests 317 Christoph Hellwig
2013-10-28 15:43 ` Dwight Engen
2013-10-30 16:19 ` Christoph Hellwig
2013-10-30 16:24 ` Christoph Hellwig
2013-10-30 18:30 ` [PATCH] xfstests: generic/317 use relative paths to avoid traversal permission problems Dwight Engen
2013-10-31 15:40 ` Christoph Hellwig
2013-11-04 20:43 ` Rich Johnston
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox