From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 17/30] db: rewrite IO engine to use libxfs
Date: Fri, 1 Nov 2013 08:59:50 +1100 [thread overview]
Message-ID: <20131031215950.GO4446@dastard> (raw)
In-Reply-To: <20131031151046.GB7457@infradead.org>
On Thu, Oct 31, 2013 at 08:10:46AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 30, 2013 at 03:31:08PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Now that we have buffers and xfs_buf_maps, it is relatively easy to
> > convert the IO engine to use libxfs routines. This gets rid of the
> > most of the differences between mapped and straight buffer reads,
> > and tracks xfs_bufs directly in the IO context that is being used.
> >
> > This is not yet a perfect solution, as xfs_db does different sized
> > IOs for the same block range which will throw warnings like:
> >
> > xfs_db> inode 64
> > 7ffff7fde740: Badness in key lookup (length)
> > bp=(bno 0x40, len 8192 bytes) key=(bno 0x40, len 4096 bytes)
> > xfs_db>
>
> Maybe we should use uncached buffer I/O in xfs_db, similar to what we do
> in the mount path in the kernel?
Possibly. I have thought about it, but we'd need a new interface and
a rework of the libxfs read/write code to do that, and that has
wider impact than just xfs_db. I also found lots of interesting
issues as a result of the re-read behaviour which I wouldn't have
easily found otherwise. i.e. the output is an early warning that
something isn't quite right in xfs_db, so it does have some use
right now.
> > mp->m_flags = (LIBXFS_MOUNT_32BITINODES|LIBXFS_MOUNT_32BITINOOPT);
> > + if (flags & LIBXFS_MOUNT_ROOTINOS)
> > + mp->m_flags |= LIBXFS_MOUNT_ROOTINOS;
> > +
> > mp->m_sb = *sb;
> > INIT_RADIX_TREE(&mp->m_perag_tree, GFP_KERNEL);
> > sbp = &(mp->m_sb);
> > @@ -866,6 +869,8 @@ libxfs_umount(xfs_mount_t *mp)
> > int agno;
> >
> > libxfs_rtmount_destroy(mp);
> > + if ((mp->m_flags & LIBXFS_MOUNT_ROOTINOS) && mp->m_rootip)
> > + libxfs_iput(mp->m_rootip, 0);
>
> Seems like the patch to remove m_rootip should go before this one?
Yeah, good idea.
> > -struct xfs_buf *
> > -libxfs_readbuf_map(struct xfs_buftarg *btp, struct xfs_buf_map *map, int nmaps,
> > - int flags, const struct xfs_buf_ops *ops)
> > +int
> > +libxfs_readbufr_map(struct xfs_buftarg *btp, struct xfs_buf *bp,
> > + struct xfs_buf_map *map, int nmaps, int flags)
>
> Shouldn't these sort of changes go into a separate patch?
I can do that.
Thanks for looking at these patches, Christoph.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-31 21:59 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 4:30 [PATCH 00/30 V3] xfsprogs: CRC write support for xfs_db Dave Chinner
2013-10-30 4:30 ` [PATCH 01/30] xfsprogs: fix automatic dependency generation Dave Chinner
2013-10-31 14:44 ` Christoph Hellwig
2013-10-30 4:30 ` [PATCH 02/30] xfs: fix some minor sparse warnings Dave Chinner
2013-10-31 14:44 ` Christoph Hellwig
2013-10-30 4:30 ` [PATCH 03/30] xfs: create a shared header file for format-related information Dave Chinner
2013-10-31 14:45 ` Christoph Hellwig
2013-10-30 4:30 ` [PATCH 04/30] xfs: split dquot buffer operations out Dave Chinner
2013-10-31 14:45 ` Christoph Hellwig
2013-10-30 4:30 ` [PATCH 05/30] xfs: decouple inode and bmap btree header files Dave Chinner
2013-10-31 14:45 ` Christoph Hellwig
2013-10-30 4:30 ` [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code Dave Chinner
2013-10-31 14:46 ` Christoph Hellwig
2013-10-30 4:30 ` [PATCH 07/30] libxfs: bmap btree owner swap support Dave Chinner
2013-10-31 14:47 ` Christoph Hellwig
2013-10-30 4:30 ` [PATCH 08/30] libxfs: xfs_rtalloc.c becomes xfs_rtbitmap.c Dave Chinner
2013-10-31 14:48 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 09/30] libxfs: bring across inode buffer readahead verifier changes Dave Chinner
2013-10-31 14:48 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 10/30] libxfs: Minor cleanup and bug fix sync Dave Chinner
2013-10-31 14:48 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 11/30] xfs: remove newlines from strings passed to __xfs_printk Dave Chinner
2013-10-31 14:49 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 12/30] xfs: fix the wrong new_size/rnew_size at xfs_iext_realloc_direct() Dave Chinner
2013-10-31 14:49 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 13/30] xfs: fix node forward in xfs_node_toosmall Dave Chinner
2013-10-31 14:49 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 14/30] xfs: don't emit corruption noise on fs probes Dave Chinner
2013-10-31 14:49 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 15/30] db: separate out straight buffer IO from map based IO Dave Chinner
2013-10-31 14:56 ` Christoph Hellwig
2013-10-31 21:50 ` Dave Chinner
2013-11-01 12:51 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 16/30] db: rewrite bbmap to use xfs_buf_map Dave Chinner
2013-10-31 15:06 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 17/30] db: rewrite IO engine to use libxfs Dave Chinner
2013-10-31 15:10 ` Christoph Hellwig
2013-10-31 21:59 ` Dave Chinner [this message]
2013-10-30 4:31 ` [PATCH 18/30] db: introduce verifier support into set_cur Dave Chinner
2013-11-01 13:07 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 19/30] db: indicate if the CRC on a buffer is correct or not Dave Chinner
2013-11-01 13:09 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 20/30] db: verify and calculate inode CRCs Dave Chinner
2013-11-04 9:05 ` Christoph Hellwig
2013-11-05 0:18 ` Dave Chinner
2013-10-30 4:31 ` [PATCH 21/30] db: verify and calculate dquot CRCs Dave Chinner
2013-11-04 9:06 ` Christoph Hellwig
2013-11-05 0:25 ` Dave Chinner
2013-10-30 4:31 ` [PATCH 22/30] db: add a special directory buffer verifier Dave Chinner
2013-11-04 9:07 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 23/30] db: add a special attribute " Dave Chinner
2013-11-04 9:07 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 24/30] db: re-enable write support for v5 filesystems Dave Chinner
2013-11-04 9:07 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 25/30] libxfs: fix root inode handling inconsistencies Dave Chinner
2013-10-30 10:23 ` Christoph Hellwig
2013-10-30 21:59 ` Dave Chinner
2013-10-31 4:13 ` [PATCH 25/30 V2] " Dave Chinner
2013-10-31 15:00 ` Christoph Hellwig
2013-10-31 22:04 ` Dave Chinner
2013-11-01 13:03 ` Christoph Hellwig
2013-11-04 23:22 ` Dave Chinner
2013-11-05 9:05 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 26/30] xfs_db: avoid libxfs buffer lookup warnings Dave Chinner
2013-11-04 9:12 ` Christoph Hellwig
2013-11-05 0:52 ` Dave Chinner
2013-11-05 9:06 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 27/30] libxfs: work around do_div() not handling 32 bit numerators Dave Chinner
2013-11-04 9:16 ` Christoph Hellwig
2013-11-05 1:55 ` Dave Chinner
2013-10-30 4:31 ` [PATCH 28/30] db: enable metadump on CRC filesystems Dave Chinner
2013-11-04 9:18 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 29/30] xfs: support larger inode clusters on v5 filesystems Dave Chinner
2013-11-04 9:18 ` Christoph Hellwig
2013-10-30 4:31 ` [PATCH 30/30] xfsprogs: kill experimental warnings for " Dave Chinner
2013-11-04 9:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031215950.GO4446@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox