From: Dave Chinner <david@fromorbit.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: bpm@sgi.com, elder@kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: [PATCH V2] xfs: simplify kmem_{zone_}zalloc
Date: Tue, 5 Nov 2013 07:59:43 +1100 [thread overview]
Message-ID: <20131104205943.GQ6188@dastard> (raw)
In-Reply-To: <52777511.1020605@cn.fujitsu.com>
On Mon, Nov 04, 2013 at 06:21:05PM +0800, Gu Zheng wrote:
> Introduce flag KM_ZERO which is used to alloc zeroed entry, and convert
> kmem_{zone_}zalloc to call kmem_{zone_}alloc() with KM_ZERO directly,
> in order to avoid the setting to zero step.
> And following Dave's suggestion, make kmem_{zone_}zalloc static inline
> into kmem.h as they're now just a simple wrapper.
>
> V2:
> Make kmem_{zone_}zalloc static inline into kmem.h as Dave suggested.
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Looks good. It also results in a slight reduction in code size:
text data bss dec hex filename
792234 99018 632 891884 d9bec fs/xfs/xfs.o.orig
792090 99018 632 891740 d9b5c fs/xfs/xfs.o
Which means making it inline hasn't cost us anything at individual
call sites.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-04 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 10:21 [PATCH V2] xfs: simplify kmem_{zone_}zalloc Gu Zheng
2013-11-04 20:59 ` Dave Chinner [this message]
2013-11-06 22:59 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104205943.GQ6188@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox