From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 37/37] repair: fix leaf node directory data check
Date: Wed, 6 Nov 2013 02:39:10 -0800 [thread overview]
Message-ID: <20131106103910.GA21067@infradead.org> (raw)
In-Reply-To: <1383700043-32305-38-git-send-email-david@fromorbit.com>
On Wed, Nov 06, 2013 at 12:07:23PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> When walking the leaf node format blocks (LEAFN) in the hash index
> of a large directory, we could trip over btree node blocks (DA_NODE)
> in the address space if there are enough entries in the directory.
> These cause a verifier failure, and hence the directory is
> considered corrupt and is trashed and rebuilt unnecesarily. Fix this
> by using the correct verifier that can handle both types of blocks
> without triggering failures.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-06 10:39 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 1:06 [PATCH 00/37 V4] xfsprogs: CRC write support for xfs_db + more Dave Chinner
2013-11-06 1:06 ` [PATCH 01/37] xfsprogs: fix automatic dependency generation Dave Chinner
2013-11-06 1:06 ` [PATCH 02/37] xfs: fix some minor sparse warnings Dave Chinner
2013-11-06 1:06 ` [PATCH 03/37] xfs: create a shared header file for format-related information Dave Chinner
2013-11-06 1:06 ` [PATCH 04/37] xfs: split dquot buffer operations out Dave Chinner
2013-11-06 1:06 ` [PATCH 05/37] xfs: decouple inode and bmap btree header files Dave Chinner
2013-11-06 1:06 ` [PATCH 06/37] libxfs: unify xfs_btree.c with kernel code Dave Chinner
2013-11-06 1:06 ` [PATCH 07/37] libxfs: bmap btree owner swap support Dave Chinner
2013-11-06 1:06 ` [PATCH 08/37] libxfs: xfs_rtalloc.c becomes xfs_rtbitmap.c Dave Chinner
2013-11-06 1:06 ` [PATCH 09/37] libxfs: bring across inode buffer readahead verifier changes Dave Chinner
2013-11-06 1:06 ` [PATCH 10/37] libxfs: Minor cleanup and bug fix sync Dave Chinner
2013-11-06 1:06 ` [PATCH 11/37] xfs: remove newlines from strings passed to __xfs_printk Dave Chinner
2013-11-06 1:06 ` [PATCH 12/37] xfs: fix the wrong new_size/rnew_size at xfs_iext_realloc_direct() Dave Chinner
2013-11-06 1:06 ` [PATCH 13/37] xfs: fix node forward in xfs_node_toosmall Dave Chinner
2013-11-06 1:07 ` [PATCH 14/37] xfs: don't emit corruption noise on fs probes Dave Chinner
2013-11-06 1:07 ` [PATCH 15/37] libxfs: fix root inode handling inconsistencies Dave Chinner
2013-11-06 10:23 ` Christoph Hellwig
2013-11-06 23:02 ` [PATCH 15/37 V2] " Dave Chinner
2013-11-07 4:58 ` [PATCH 15/37 V3] " Dave Chinner
2013-11-07 8:11 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 16/37] libxfs: stop caching inode structures Dave Chinner
2013-11-06 1:07 ` [PATCH 17/37] db: separate out straight buffer IO from map based IO Dave Chinner
2013-11-07 20:50 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 18/37] db: rewrite bbmap to use xfs_buf_map Dave Chinner
2013-11-06 1:07 ` [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db Dave Chinner
2013-11-07 20:51 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 20/37] db: rewrite IO engine to use libxfs Dave Chinner
2013-11-06 1:07 ` [PATCH 21/37] db: introduce verifier support into set_cur Dave Chinner
2013-11-06 1:07 ` [PATCH 22/37] db: indicate if the CRC on a buffer is correct or not Dave Chinner
2013-11-06 1:07 ` [PATCH 23/37] db: verify and calculate inode CRCs Dave Chinner
2013-11-06 1:07 ` [PATCH 24/37] db: verify and calculate dquot CRCs Dave Chinner
2013-11-06 1:07 ` [PATCH 25/37] db: add a special directory buffer verifier Dave Chinner
2013-11-06 1:07 ` [PATCH 26/37] db: add a special attribute " Dave Chinner
2013-11-06 1:07 ` [PATCH 27/37] db: re-enable write support for v5 filesystems Dave Chinner
2013-11-06 1:07 ` [PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings Dave Chinner
2013-11-06 2:20 ` Dave Chinner
2013-11-07 20:52 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 29/37] " Dave Chinner
2013-11-07 20:54 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 30/37] libxfs: work around do_div() not handling 32 bit numerators Dave Chinner
2013-11-07 20:54 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 31/37] db: Unwind the IO stack on exit Dave Chinner
2013-11-07 20:55 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 32/37] db: enable metadump on CRC filesystems Dave Chinner
2013-11-06 1:07 ` [PATCH 33/37] xfs: support larger inode clusters on v5 filesystems Dave Chinner
2013-11-06 1:07 ` [PATCH 34/37] xfsprogs: kill experimental warnings for " Dave Chinner
2013-11-06 1:07 ` [PATCH 35/37] repair: prefetching is turned off unnecessarily Dave Chinner
2013-11-06 10:45 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 36/37] repair: Increase default repair parallelism on large filesystems Dave Chinner
2013-11-06 10:41 ` Christoph Hellwig
2013-11-06 19:13 ` Dave Chinner
2013-11-12 23:38 ` Dave Chinner
2013-11-13 7:55 ` Christoph Hellwig
2013-11-06 1:07 ` [PATCH 37/37] repair: fix leaf node directory data check Dave Chinner
2013-11-06 10:39 ` Christoph Hellwig [this message]
2013-11-06 10:19 ` [PATCH 00/37 V4] xfsprogs: CRC write support for xfs_db + more Christoph Hellwig
2013-11-06 19:15 ` Dave Chinner
2013-11-10 1:05 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106103910.GA21067@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox