From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 81CC129E23 for ; Wed, 6 Nov 2013 04:39:11 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 4A5CC30407B for ; Wed, 6 Nov 2013 02:39:11 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id zrO4wuEsHhLR6vCq (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Wed, 06 Nov 2013 02:39:10 -0800 (PST) Date: Wed, 6 Nov 2013 02:39:10 -0800 From: Christoph Hellwig Subject: Re: [PATCH 37/37] repair: fix leaf node directory data check Message-ID: <20131106103910.GA21067@infradead.org> References: <1383700043-32305-1-git-send-email-david@fromorbit.com> <1383700043-32305-38-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1383700043-32305-38-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Wed, Nov 06, 2013 at 12:07:23PM +1100, Dave Chinner wrote: > From: Dave Chinner > > When walking the leaf node format blocks (LEAFN) in the hash index > of a large directory, we could trip over btree node blocks (DA_NODE) > in the address space if there are enough entries in the directory. > These cause a verifier failure, and hence the directory is > considered corrupt and is trashed and rebuilt unnecesarily. Fix this > by using the correct verifier that can handle both types of blocks > without triggering failures. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs