From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 2F1D47FD1 for ; Thu, 7 Nov 2013 00:58:41 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 99827AC006 for ; Wed, 6 Nov 2013 22:58:37 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id SHBnbsEW7jAZkTyj (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Wed, 06 Nov 2013 22:58:36 -0800 (PST) Date: Wed, 6 Nov 2013 22:58:35 -0800 From: Christoph Hellwig Subject: Re: [PATCH] xfsdump: don't assume getdents exists Message-ID: <20131107065835.GA24345@infradead.org> References: <20131106213635.GC24712@redacted.bos.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131106213635.GC24712@redacted.bos.redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Kyle McMartin Cc: sandeen@redhat.com, xfs@oss.sgi.com On Wed, Nov 06, 2013 at 04:36:35PM -0500, Kyle McMartin wrote: > New Linux ports are using a standard syscall list that does not include > deprecated syscalls where 64-bit clean alternatives exist. As a result, > on arm64, __NR_getdents is undefined, resulting in xfsdump failing to > build. > > To avoid that, in the case where __NR_getdents is unset in unistd.h, > avoid building the fallback path entirely, since > __ASSUME_GETDENTS64_SYSCALL will be true, the SYS_getdents64 case will > be the primary (and only) path used. Seems like we could drop this mess of a file entirely and just rely on getdents64 from glibc. The raison d'etre of that file appears to support 64 bit getdents before glibc really supported it, and I don't think we'll have to support such old configurations anymore. I'll give it a quick spin and see how that works out. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs